The database moved to a container of our own; the platform is gone. This takes out what was left of it — and, where the leftovers were load bearing, moves rather than deletes. Moved, not deleted: supabase/migrations/ -> db/migrations/ the schema's source of truth supabase/build-org.ts -> scripts/build-org.ts lib/supabase/types.ts -> lib/types.ts 52 import sites repointed The bookkeeping needed care. It lived in `supabase_migrations.schema_migrations`, and simply renaming the schema would have left the runner facing an empty table: it would have called all 67 migrations pending and replayed them against a database that is long since current. So the runner now creates `migrationen.schema_migrations` and, once, copies the old rows across — guarded so a second run does nothing and a fresh database skips it entirely. Only then does migration 20260907100000 drop the old schema. Deleted: the CLI config, the seed, the historical schema/function dumps (nothing read them), scripts/umzug-von-supabase.sh (the move is done), and both Supabase packages plus the CLI. Nothing in the application imported them — the build now succeeds with no environment variables at all, which is the proof. Integration tests: six of them signed in through Supabase Auth and asserted against the anon key and the service role. That model is gone, so the tests were not portable — they are deleted. session-context and employee-status-filter already ran on pg and are untouched; om-reporting is ported to a direct connection because it guards a real risk (the reporting line rule exists twice, once in SQL and once in TypeScript). CI: the integration job started a Supabase stack. It now runs a postgres service, applies deploy/db-init and every migration to an empty database — that was the valuable part, and it still holds — then checks that a second run is a no-op, which is what proves the bookkeeping works. Docs: security-review.md audited a service-role key, a cookie adapter and auth.users, none of which exist. Restating findings about removed components would suggest today's system had been reviewed; it has not. It now records what was removed and says a fresh review is due. data-model.md was already marked obsolete and described the pre-OM schema; azure-migration.md was a plan for a route not taken. Both deleted. Verified: npm ci, typecheck, lint, 445 tests, build — all clean without the packages. Integration tests skip cleanly with no database. Migration SQL and the runner are reviewed but NOT executed: no Docker here, and the old instance no longer resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
95 lines
3.4 KiB
TypeScript
95 lines
3.4 KiB
TypeScript
import { Kysely, PostgresDialect } from "kysely";
|
|
import { Pool } from "pg";
|
|
import { afterAll, describe, expect, it } from "vitest";
|
|
import { derivedStatusFilter } from "@/lib/employee-status-filter";
|
|
import type { Schema } from "@/lib/db/schema";
|
|
import { todayIso } from "@/lib/format";
|
|
import { deriveStatusAsOf } from "@/lib/reports";
|
|
import type { EmploymentStatus } from "@/lib/types";
|
|
|
|
// lib/employee-status-filter.ts is a SQL restatement of deriveStatusAsOf():
|
|
// the employee list pages in the database and cannot derive status in JS, so
|
|
// the same rule exists twice. Two copies of a rule drift, and the drift is
|
|
// invisible — a dashboard tile and the list it links to just quietly show
|
|
// different numbers.
|
|
//
|
|
// Only a real database can settle it, so this runs both over the whole
|
|
// seeded roster and demands the same set of ids.
|
|
//
|
|
// Eigene Verbindung statt der Zugriffsschicht: geprüft wird die Bedingung,
|
|
// nicht die Berechtigung. Mit RLS dazwischen liefe der Test gegen eine
|
|
// gefilterte Teilmenge und bewiese nichts über die Regel.
|
|
const db = new Kysely<Schema>({
|
|
dialect: new PostgresDialect({ pool: new Pool({ connectionString: process.env.DATABASE_URL, max: 2 }) }),
|
|
});
|
|
|
|
describe.skipIf(!process.env.DATABASE_URL)("derived status filter matches deriveStatusAsOf", () => {
|
|
const asOf = todayIso();
|
|
|
|
afterAll(async () => {
|
|
await db.destroy();
|
|
});
|
|
|
|
async function idsFromDatabase(statuses: EmploymentStatus[]): Promise<Set<string>> {
|
|
const rows = await db
|
|
.selectFrom("employees")
|
|
.select("id")
|
|
.where((eb) => derivedStatusFilter(eb, statuses, asOf) ?? eb.val(true))
|
|
.execute();
|
|
return new Set(rows.map((r) => r.id));
|
|
}
|
|
|
|
async function idsFromDerivation(statuses: EmploymentStatus[]): Promise<Set<string>> {
|
|
const rows = await db
|
|
.selectFrom("employees")
|
|
.select(["id", "entry_date", "exit_date", "karenz_start_date", "karenz_return_date"])
|
|
.execute();
|
|
return new Set(rows.filter((e) => statuses.includes(deriveStatusAsOf(e, asOf))).map((e) => e.id));
|
|
}
|
|
|
|
async function expectSameSet(statuses: EmploymentStatus[]) {
|
|
const [fromDb, fromJs] = await Promise.all([idsFromDatabase(statuses), idsFromDerivation(statuses)]);
|
|
|
|
const onlyInDb = [...fromDb].filter((id) => !fromJs.has(id));
|
|
const onlyInJs = [...fromJs].filter((id) => !fromDb.has(id));
|
|
|
|
expect({ statuses, onlyInDb: onlyInDb.slice(0, 5), onlyInJs: onlyInJs.slice(0, 5) }).toEqual({
|
|
statuses,
|
|
onlyInDb: [],
|
|
onlyInJs: [],
|
|
});
|
|
// Guards against a filter so narrow it matches nothing and passes
|
|
// trivially.
|
|
expect(fromJs.size).toBeGreaterThan(0);
|
|
}
|
|
|
|
it("agrees for Aktiv + Karenz — the definition the dashboard headcount uses", async () => {
|
|
await expectSameSet(["Aktiv", "Karenz"]);
|
|
});
|
|
|
|
it("agrees for Aktiv alone", async () => {
|
|
await expectSameSet(["Aktiv"]);
|
|
});
|
|
|
|
it("agrees for Karenz alone", async () => {
|
|
await expectSameSet(["Karenz"]);
|
|
});
|
|
|
|
it("agrees for Geplant", async () => {
|
|
await expectSameSet(["Geplant"]);
|
|
});
|
|
|
|
it("agrees for Ausgetreten", async () => {
|
|
await expectSameSet(["Ausgetreten"]);
|
|
});
|
|
|
|
it("returns everyone when no status is selected", async () => {
|
|
const total = await db
|
|
.selectFrom("employees")
|
|
.select(({ fn }) => fn.countAll<string>().as("anzahl"))
|
|
.executeTakeFirstOrThrow();
|
|
const filtered = await idsFromDatabase([]);
|
|
expect(filtered.size).toBe(Number(total.anzahl));
|
|
});
|
|
});
|