Maximilian Stubhan
b87c8ad64c
The database moved to a container of our own; the platform is gone. This takes out what was left of it — and, where the leftovers were load bearing, moves rather than deletes. Moved, not deleted: supabase/migrations/ -> db/migrations/ the schema's source of truth supabase/build-org.ts -> scripts/build-org.ts lib/supabase/types.ts -> lib/types.ts 52 import sites repointed The bookkeeping needed care. It lived in `supabase_migrations.schema_migrations`, and simply renaming the schema would have left the runner facing an empty table: it would have called all 67 migrations pending and replayed them against a database that is long since current. So the runner now creates `migrationen.schema_migrations` and, once, copies the old rows across — guarded so a second run does nothing and a fresh database skips it entirely. Only then does migration 20260907100000 drop the old schema. Deleted: the CLI config, the seed, the historical schema/function dumps (nothing read them), scripts/umzug-von-supabase.sh (the move is done), and both Supabase packages plus the CLI. Nothing in the application imported them — the build now succeeds with no environment variables at all, which is the proof. Integration tests: six of them signed in through Supabase Auth and asserted against the anon key and the service role. That model is gone, so the tests were not portable — they are deleted. session-context and employee-status-filter already ran on pg and are untouched; om-reporting is ported to a direct connection because it guards a real risk (the reporting line rule exists twice, once in SQL and once in TypeScript). CI: the integration job started a Supabase stack. It now runs a postgres service, applies deploy/db-init and every migration to an empty database — that was the valuable part, and it still holds — then checks that a second run is a no-op, which is what proves the bookkeeping works. Docs: security-review.md audited a service-role key, a cookie adapter and auth.users, none of which exist. Restating findings about removed components would suggest today's system had been reviewed; it has not. It now records what was removed and says a fresh review is due. data-model.md was already marked obsolete and described the pre-OM schema; azure-migration.md was a plan for a route not taken. Both deleted. Verified: npm ci, typecheck, lint, 445 tests, build — all clean without the packages. Integration tests skip cleanly with no database. Migration SQL and the runner are reviewed but NOT executed: no Docker here, and the old instance no longer resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
39 lines
2.0 KiB
SQL
39 lines
2.0 KiB
SQL
-- Deferred/effective-dated changes (spec §3.3)
|
|
--
|
|
-- Finding from the consolidation review: transfer_employee, promote_employee,
|
|
-- start_karenz, change_employee_data, and apply_reorg all accepted a
|
|
-- "Wirksam ab" / effective date, but only ever used it as metadata for the
|
|
-- employee_history/audit_log rows — the actual `update employees` always
|
|
-- ran immediately regardless of that date. A transfer or promotion dated
|
|
-- months in the future silently overwrote the *current* live record today.
|
|
-- This table backs the fix: when an effective date is in the future, the
|
|
-- mutating RPC stores the intended change here instead of writing it to
|
|
-- `employees` right away; a scheduled job (apply_due_pending_changes(),
|
|
-- see the following migration, invoked by a Vercel Cron route handler)
|
|
-- applies it once its date arrives. The employee_history/audit_log rows are
|
|
-- written immediately either way (dated with the effective date), which is
|
|
-- what already drives the "zukünftig" badge in the Historie tab.
|
|
|
|
create table pending_org_changes (
|
|
id uuid primary key default gen_random_uuid(),
|
|
employee_id uuid not null references employees(id) on delete cascade,
|
|
change_type text not null check (change_type in (
|
|
'transfer', 'promotion', 'karenz_start', 'karenz_return', 'contract_change', 'reorg'
|
|
)),
|
|
effective_date date not null,
|
|
payload jsonb not null,
|
|
reorg_scenario_id uuid references reorg_scenarios(id) on delete cascade,
|
|
status text not null default 'pending' check (status in ('pending', 'applied', 'cancelled')),
|
|
created_by uuid references auth.users(id),
|
|
created_at timestamptz not null default now(),
|
|
applied_at timestamptz
|
|
);
|
|
|
|
create index on pending_org_changes (employee_id);
|
|
create index on pending_org_changes (status, effective_date);
|
|
create index on pending_org_changes (reorg_scenario_id);
|
|
|
|
alter table pending_org_changes enable row level security;
|
|
create policy "pending_org_changes_hr_all" on pending_org_changes for all
|
|
using (is_hr_user()) with check (is_hr_user());
|