Accessibility work on the UI layer, all of it rooted in one structural gap: there were no form primitives, so every field was hand-assembled and every field got the same details wrong. Form primitives - components/ui/Field.tsx (Field/TextField/SelectField/TextareaField) and Button.tsx. Field generates the control id with useId and derives htmlFor from it, which is what makes the association impossible to omit rather than merely conventional. - 92 labels existed, 4 used htmlFor, and no input carried an id at all: a screen reader announced an unnamed edit box and clicking a label focused nothing. Now every label resolves to its control (0 unassociated), and the input class chain that appeared verbatim 85 times appears zero times. - Field also takes a render prop, so Lookup, CountryPicker and Picklist get the same wiring instead of a second, partial solution. - SearchInput replaces three hand-rolled copies of the icon-in-a-box search whose input had only a placeholder — not a label — and killed its own focus ring with outline-none and nothing in its place. - Toggle groups (workdays, reorg change type) became fieldsets with aria-pressed; colour alone was carrying the selected state. Comboboxes - Lookup and CountryPicker were text inputs with a div of clickable buttons underneath: typeable, but no keyboard path to a result and nothing telling a screen reader a list had appeared. Both now carry role=combobox, aria-expanded/controls/activedescendant and listbox semantics, with arrow keys, Enter and Escape. Escape stops propagation, or it would close the surrounding dialog along with the dropdown. Dialogs - useDialogFocus centralises what Modal and SlideOver each owed the keyboard and neither provided beyond Escape: focus into the dialog on open, Tab and Shift+Tab cycling within it, focus restored to the trigger on close. - SlideOver stays mounted for its transition, and aria-hidden does not remove anything from the tab order — so every closed panel was leaving invisible tab stops at the end of the page. `inert` fixes that. Route states - loading.tsx, error.tsx, not-found.tsx and global-error.tsx. Every page in the (app) group is server-rendered per request, so without loading.tsx a navigation showed nothing at all until the server answered, and a render error dropped the user on Next's own screen with no way back. Tests - 22 component tests (vitest jsdom project). Two of them found limits of the environment rather than of the code: jsdom implements neither `inert` nor scrollIntoView, so the inert test asserts the attribute and the missing scrollIntoView — which was taking the whole render down from inside an effect — is stubbed in the setup file.
139 lines
4.6 KiB
TypeScript
139 lines
4.6 KiB
TypeScript
"use client";
|
|
|
|
import { useRouter } from "next/navigation";
|
|
import { useState } from "react";
|
|
import { createPosition, searchSuperiors, type SuperiorSearchResult } from "@/actions/positions";
|
|
import { Button } from "@/components/ui/Button";
|
|
import { Field, SelectField, TextField } from "@/components/ui/Field";
|
|
import { Lookup } from "@/components/ui/Lookup";
|
|
import { Modal } from "@/components/ui/Modal";
|
|
import { useToast } from "@/components/ui/Toast";
|
|
import { todayIso } from "@/lib/format";
|
|
import type { Database } from "@/lib/supabase/types";
|
|
|
|
type Team = Database["public"]["Tables"]["teams"]["Row"];
|
|
|
|
export function CreatePositionModal({ open, onClose, teams }: { open: boolean; onClose: () => void; teams: Team[] }) {
|
|
const { showToast } = useToast();
|
|
const router = useRouter();
|
|
const [title, setTitle] = useState("");
|
|
const [isLead, setIsLead] = useState(false);
|
|
const [superior, setSuperior] = useState<SuperiorSearchResult | null>(null);
|
|
const [teamId, setTeamId] = useState("");
|
|
const [validFrom, setValidFrom] = useState(todayIso);
|
|
const [pending, setPending] = useState(false);
|
|
|
|
function reset() {
|
|
setTitle("");
|
|
setIsLead(false);
|
|
setSuperior(null);
|
|
setTeamId("");
|
|
setValidFrom(todayIso());
|
|
}
|
|
|
|
async function handleSubmit() {
|
|
if (!title || !superior || !validFrom || (isLead && !teamId)) {
|
|
showToast("Bitte alle Pflichtfelder ausfüllen.", "error");
|
|
return;
|
|
}
|
|
setPending(true);
|
|
const result = await createPosition({
|
|
title,
|
|
superior_employee_id: superior.id,
|
|
is_lead: isLead,
|
|
team_id: isLead ? teamId : undefined,
|
|
valid_from: validFrom,
|
|
});
|
|
setPending(false);
|
|
if (result.success) {
|
|
showToast("Position ausgeschrieben.");
|
|
router.refresh();
|
|
onClose();
|
|
reset();
|
|
} else {
|
|
showToast(result.error ?? "Fehler beim Anlegen.", "error");
|
|
}
|
|
}
|
|
|
|
return (
|
|
<Modal
|
|
open={open}
|
|
onClose={onClose}
|
|
title="Position ausschreiben"
|
|
footer={
|
|
<>
|
|
<Button variant="ghost" onClick={onClose}>
|
|
Abbrechen
|
|
</Button>
|
|
<Button onClick={handleSubmit} pending={pending}>
|
|
Ausschreiben
|
|
</Button>
|
|
</>
|
|
}
|
|
>
|
|
<div className="flex flex-col gap-4">
|
|
<TextField label="Titel" required value={title} onChange={setTitle} />
|
|
<label className="flex items-center gap-2 text-sm text-ink-body">
|
|
<input
|
|
type="checkbox"
|
|
checked={isLead}
|
|
onChange={(e) => {
|
|
setIsLead(e.target.checked);
|
|
setSuperior(null);
|
|
}}
|
|
/>
|
|
Führungsposition (Teamleitung)
|
|
</label>
|
|
{!superior ? (
|
|
<Field label={isLead ? "Übergeordnete Bereichsleitung" : "Übergeordnete Teamleitung"} required>
|
|
{(p) => (
|
|
<Lookup<SuperiorSearchResult>
|
|
{...p}
|
|
placeholder="Name oder Titel…"
|
|
onSearch={(q) => searchSuperiors(q, isLead)}
|
|
onSelect={setSuperior}
|
|
renderResult={(r) => (
|
|
<div>
|
|
<div className="font-semibold text-ink">
|
|
{r.first_name} {r.last_name}
|
|
</div>
|
|
<div className="text-xs text-ink-muted">{r.job_title}</div>
|
|
</div>
|
|
)}
|
|
/>
|
|
)}
|
|
</Field>
|
|
) : (
|
|
<div>
|
|
<p className="mb-1 block text-sm font-semibold text-ink">
|
|
{isLead ? "Übergeordnete Bereichsleitung" : "Übergeordnete Teamleitung"}
|
|
</p>
|
|
<div className="flex items-center justify-between rounded border border-border bg-surface p-3">
|
|
<div>
|
|
<div className="text-sm font-semibold text-ink">
|
|
{superior.first_name} {superior.last_name}
|
|
</div>
|
|
<div className="text-xs text-ink-muted">{superior.job_title}</div>
|
|
</div>
|
|
<Button variant="ghost" size="sm" onClick={() => setSuperior(null)}>
|
|
Ändern
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
)}
|
|
{isLead && (
|
|
<SelectField
|
|
label="Zu leitendes Team"
|
|
required
|
|
value={teamId}
|
|
onChange={setTeamId}
|
|
placeholder="Bitte wählen…"
|
|
options={teams.map((t) => ({ value: t.id, label: t.name }))}
|
|
/>
|
|
)}
|
|
<TextField label="Gültig ab" required type="date" value={validFrom} onChange={setValidFrom} />
|
|
</div>
|
|
</Modal>
|
|
);
|
|
}
|