Maximilian Stubhan
b87c8ad64c
The database moved to a container of our own; the platform is gone. This takes out what was left of it — and, where the leftovers were load bearing, moves rather than deletes. Moved, not deleted: supabase/migrations/ -> db/migrations/ the schema's source of truth supabase/build-org.ts -> scripts/build-org.ts lib/supabase/types.ts -> lib/types.ts 52 import sites repointed The bookkeeping needed care. It lived in `supabase_migrations.schema_migrations`, and simply renaming the schema would have left the runner facing an empty table: it would have called all 67 migrations pending and replayed them against a database that is long since current. So the runner now creates `migrationen.schema_migrations` and, once, copies the old rows across — guarded so a second run does nothing and a fresh database skips it entirely. Only then does migration 20260907100000 drop the old schema. Deleted: the CLI config, the seed, the historical schema/function dumps (nothing read them), scripts/umzug-von-supabase.sh (the move is done), and both Supabase packages plus the CLI. Nothing in the application imported them — the build now succeeds with no environment variables at all, which is the proof. Integration tests: six of them signed in through Supabase Auth and asserted against the anon key and the service role. That model is gone, so the tests were not portable — they are deleted. session-context and employee-status-filter already ran on pg and are untouched; om-reporting is ported to a direct connection because it guards a real risk (the reporting line rule exists twice, once in SQL and once in TypeScript). CI: the integration job started a Supabase stack. It now runs a postgres service, applies deploy/db-init and every migration to an empty database — that was the valuable part, and it still holds — then checks that a second run is a no-op, which is what proves the bookkeeping works. Docs: security-review.md audited a service-role key, a cookie adapter and auth.users, none of which exist. Restating findings about removed components would suggest today's system had been reviewed; it has not. It now records what was removed and says a fresh review is due. data-model.md was already marked obsolete and described the pre-OM schema; azure-migration.md was a plan for a route not taken. Both deleted. Verified: npm ci, typecheck, lint, 445 tests, build — all clean without the packages. Integration tests skip cleanly with no database. Migration SQL and the runner are reviewed but NOT executed: no Docker here, and the old instance no longer resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
57 lines
2.2 KiB
TypeScript
57 lines
2.2 KiB
TypeScript
import "server-only";
|
|
import { sql, withUser, type Tx } from "./index";
|
|
import type { Database } from "@/lib/types";
|
|
|
|
// Aufruf einer Datenbankfunktion.
|
|
//
|
|
// Die Geschäftslogik liegt in PL/pgSQL — Eintritt, Versetzung, Austritt und
|
|
// die übrigen zehn Mutationen. Daran ändert der Wechsel des Zugriffswegs
|
|
// nichts: es fällt nur die API-Schicht dazwischen weg. Aufgerufen wird die
|
|
// Funktion jetzt unmittelbar, innerhalb der Transaktion, in der auch der
|
|
// Sitzungskontext gilt — ohne den würde require_hr_admin() darin abweisen.
|
|
|
|
export type MutationFn = keyof Database["public"]["Functions"];
|
|
|
|
/**
|
|
* Ruft `fn(payload)` innerhalb der laufenden Transaktion auf.
|
|
*
|
|
* `payload` weglassen für die Funktionen ohne Argument —
|
|
* apply_due_pending_changes() ist die einzige. Mit einem jsonb-Argument
|
|
* aufgerufen fände Postgres keine passende Signatur.
|
|
*/
|
|
export async function callFunction(tx: Tx, fn: MutationFn, payload?: Record<string, unknown>): Promise<unknown> {
|
|
// Der Funktionsname stammt aus einer geschlossenen Aufzählung, nie aus
|
|
// einer Eingabe — sonst wäre die Verkettung hier eine Einladung.
|
|
const name = sql.raw(`"${fn}"`);
|
|
const query =
|
|
payload === undefined
|
|
? sql<{ result: unknown }>`select ${name}() as result`
|
|
: sql<{ result: unknown }>`select ${name}(${sql.val(JSON.stringify(payload))}::jsonb) as result`;
|
|
const result = await query.execute(tx);
|
|
return result.rows[0]?.result;
|
|
}
|
|
|
|
export type ActionResult = { success: boolean; error?: string };
|
|
|
|
/**
|
|
* Eine Mutation im Namen der angemeldeten Person, mit der üblichen
|
|
* Fehlerbehandlung für Server Actions.
|
|
*
|
|
* Die Prüfung der Berechtigung passiert in der Funktion selbst
|
|
* (require_hr_admin) und unabhängig davon in den RLS-Policies — nicht hier.
|
|
*/
|
|
export async function runMutation(
|
|
userId: string | null,
|
|
fn: MutationFn,
|
|
payload: Record<string, unknown>
|
|
): Promise<ActionResult> {
|
|
try {
|
|
await withUser(userId, (tx) => callFunction(tx, fn, payload));
|
|
return { success: true };
|
|
} catch (err) {
|
|
// Die Meldungen der Funktionen sind für die Oberfläche geschrieben
|
|
// („Diese Planstelle ist bereits besetzt.") und werden durchgereicht.
|
|
return { success: false, error: err instanceof Error ? err.message : "Unbekannter Fehler." };
|
|
}
|
|
}
|