Maximilian Stubhan
79f0e19bf8
Data model - employee_assignments records org placement over time (valid_from/valid_to), written by a trigger on `employees` rather than inside each RPC: ~70 `update employees` statements spread over fifteen migrations mean per-call bookkeeping would miss paths today and again with every future RPC. A partial unique index enforces the one-open-interval invariant the trigger relies on when closing the current row. - The Organigramm gains a Stichtag (default today). Membership comes from entry/exit/karenz, past placement from the new history, future placement projected from pending_org_changes. Placements predating the migration are backfilled with today's values and flagged as such in the UI, since employee_history only ever stored free text and cannot be reconstructed. Correctness - Reports and exports silently truncated at PostgREST's 1000-row cap (db.max_rows); employee_history is already past it at ~800 staff. Every whole-table read now pages explicitly. - XLSX date cells were a day early: ExcelJS converts a Date to an Excel serial straight off getTime(), so a Date built at local midnight lands on the previous day's serial in any positive-offset zone. - Date handling is pinned to Europe/Vienna throughout, and date-only strings are formatted without a Date round-trip. The dashboard's YTD window was built by round-tripping a local Date through toISOString(), which shifted it a day early and dropped 31 December entirely. - Export routes parsed measure/group/split/eventType with unchecked `as` casts, so an unknown value reached column headers as `undefined` and the Content-Disposition filename. Parsed against the label maps now, with the filename slugged as a backstop. - toXlsx keyed columns by header text, silently dropping the second of any two columns sharing a name — split columns take their header from data. - The org chart tree walks had no cycle guard; nothing in the schema forbids a manager_id cycle, and one would hang the tab rather than misreport. - The login page reflected ?error= verbatim, letting anyone put arbitrary text on the real sign-in screen; messages are looked up by code now. - React Flow needs elementsSelectable on, or it sets pointer-events:none on the whole node and the expand control stops responding. UI - Mobile: the shell was unusable below lg — a fixed 236px margin pushed content off-screen with no mobile navigation at all. The sidebar is now a drawer, dvh replaces vh, safe-area insets are honoured, inputs are 16px so iOS stops zooming on focus, and form grids stack. - Org chart nodes redesigned: per-kind accent stripes and icons, vacant roles called out, expand control moved to the bottom edge carrying the child count. - Pagination is windowed; it previously rendered one link per page (54 for the employee list, unbounded for the audit log). - Positions page reduced to open positions with a single "Besetzen" action. - The employee Organisation tab links into the org chart focused on that person, reusing the chart's existing search-match highlighting. Also included, uncommitted until now - Dependants, HR notes, academic titles, split address fields, position validity and role/employment fields, with their migrations and UI. - Docker/compose deployment setup, data-model and security-review docs.
74 lines
3.0 KiB
TypeScript
74 lines
3.0 KiB
TypeScript
import { Network } from "lucide-react";
|
|
import Link from "next/link";
|
|
import { Avatar } from "@/components/ui/Avatar";
|
|
|
|
type MiniEmployee = { id: string; first_name: string; last_name: string; job_title: string; status?: string };
|
|
|
|
type OrganisationTabProps = {
|
|
employeeId: string;
|
|
manager: MiniEmployee | null;
|
|
directReports: MiniEmployee[];
|
|
breadcrumb: string;
|
|
};
|
|
|
|
export function OrganisationTab({ employeeId, manager, directReports, breadcrumb }: OrganisationTabProps) {
|
|
return (
|
|
<div className="flex flex-col gap-6">
|
|
<div className="flex flex-wrap items-start justify-between gap-3">
|
|
<div>
|
|
<h3 className="text-xs font-semibold uppercase tracking-wide text-ink-muted">Organisationseinheit</h3>
|
|
<p className="mt-1 text-sm text-ink">{breadcrumb}</p>
|
|
</div>
|
|
{/* ?focus= drives the same highlight/auto-expand path the org chart
|
|
search already uses, so the person is unfolded and centred on
|
|
arrival instead of the user hunting for them. */}
|
|
<Link
|
|
href={`/orgchart?focus=${employeeId}`}
|
|
className="flex items-center gap-1.5 rounded border border-border px-3 py-2 text-sm font-semibold text-ink-body hover:bg-surface"
|
|
>
|
|
<Network className="h-4 w-4" />
|
|
Im Organigramm anzeigen
|
|
</Link>
|
|
</div>
|
|
|
|
<div>
|
|
<h3 className="mb-2 text-xs font-semibold uppercase tracking-wide text-ink-muted">Führungskraft</h3>
|
|
{manager ? (
|
|
<Link href={`/employees/${manager.id}`} className="flex w-fit items-center gap-3 rounded border border-border p-3 hover:bg-surface">
|
|
<Avatar firstName={manager.first_name} lastName={manager.last_name} />
|
|
<div>
|
|
<div className="text-sm font-semibold text-ink">
|
|
{manager.first_name} {manager.last_name}
|
|
</div>
|
|
<div className="text-xs text-ink-muted">{manager.job_title}</div>
|
|
</div>
|
|
</Link>
|
|
) : (
|
|
<p className="text-sm text-ink-muted">Keine Führungskraft (Geschäftsführung)</p>
|
|
)}
|
|
</div>
|
|
|
|
<div>
|
|
<h3 className="mb-2 text-xs font-semibold uppercase tracking-wide text-ink-muted">Direkte Berichte ({directReports.length})</h3>
|
|
{directReports.length > 0 ? (
|
|
<div className="grid grid-cols-1 gap-2 sm:grid-cols-2 lg:grid-cols-3">
|
|
{directReports.map((r) => (
|
|
<Link key={r.id} href={`/employees/${r.id}`} className="flex items-center gap-3 rounded border border-border p-3 hover:bg-surface">
|
|
<Avatar firstName={r.first_name} lastName={r.last_name} />
|
|
<div>
|
|
<div className="text-sm font-semibold text-ink">
|
|
{r.first_name} {r.last_name}
|
|
</div>
|
|
<div className="text-xs text-ink-muted">{r.job_title}</div>
|
|
</div>
|
|
</Link>
|
|
))}
|
|
</div>
|
|
) : (
|
|
<p className="text-sm text-ink-muted">Keine direkten Berichte.</p>
|
|
)}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|