HR can now delete a history entry, but only where deleting one is an honest thing to do — and deleting it also undoes it. The rule they asked for is the interesting part: the last valid change wins. Deleting an entry walks its fields one at a time. If a later entry touched the same field, the current value stays — that later change is the one in force. Otherwise the field goes back to what the deleted entry recorded as its "before". So the middle of three entries can be removed without an old value overwriting a newer one. Four kinds of entry refuse to be deleted, each saying why in the place the button would have been. Eintritt anchors the timeline. Transfers, promotions, absences and exits moved positions and status — they have proper operations for that, and guessing backwards is how you corrupt an org chart. Anything not yet effective hangs off a planned change, and that link is not trustworthy: there is no key between a history row and its pending row, only a person and a date, and the data already has an Eintritt and a Vertragsänderung sharing one. Matching on the date would eventually cancel a change nobody meant. And entries from before the history carried values have nothing to fall back to. Confirmation is not "are you sure" — that question gets a reflex yes by the third time. The dialog says what will be different afterwards: which field goes back to which value, and which one stays because something later claimed it. employee_history keeps its append-only policies; delete_history_entry is SECURITY DEFINER and checks the permission itself in its first line. The audit log keeps the deletion with the values that were removed, and the audit log genuinely cannot be edited. The rule lives twice — in SQL and in lib/history.ts. The database is the authority; the copy exists so the UI can hide a button that would fail and print the reason instead. Rehearsed against real data in a rolled-back transaction first: the later change held, the untouched field reverted, all four refusals fired. Also corrected in the data catalogue: I had written that require_hr_admin was called by nothing. It guards all sixteen mutating functions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
195 lines
8.5 KiB
TypeScript
195 lines
8.5 KiB
TypeScript
"use client";
|
|
|
|
import { ArrowLeft, ArrowRightLeft, Clock, Pencil, RotateCcw, TrendingUp, XCircle } from "lucide-react";
|
|
import Link from "next/link";
|
|
import { useState } from "react";
|
|
import { Avatar } from "@/components/ui/Avatar";
|
|
import { Button } from "@/components/ui/Button";
|
|
import { StatusChip } from "@/components/ui/StatusChip";
|
|
import { fmtFullName, tenure } from "@/lib/format";
|
|
import type { OpenPositionResolved } from "@/lib/positions";
|
|
import type { Database } from "@/lib/supabase/types";
|
|
import { DatenAendernPanel } from "./panels/DatenAendernPanel";
|
|
import { KarenzPanel } from "./panels/KarenzPanel";
|
|
import { PromotePanel } from "./panels/PromotePanel";
|
|
import { RehirePanel } from "./panels/RehirePanel";
|
|
import { TerminatePanel } from "./panels/TerminatePanel";
|
|
import { TransferPanel } from "./panels/TransferPanel";
|
|
import { HistorieTab } from "./tabs/HistorieTab";
|
|
import { NotizenTab } from "./tabs/NotizenTab";
|
|
import { OrganisationTab } from "./tabs/OrganisationTab";
|
|
import { StammdatenTab } from "./tabs/StammdatenTab";
|
|
import { VertragTab } from "./tabs/VertragTab";
|
|
|
|
type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
|
|
type Location = Database["public"]["Tables"]["locations"]["Row"];
|
|
type HistoryRow = Database["public"]["Tables"]["employee_history"]["Row"];
|
|
type Dependent = Database["public"]["Tables"]["employee_dependents"]["Row"];
|
|
type NoteRow = Database["public"]["Tables"]["employee_notes"]["Row"];
|
|
type MiniEmployee = { id: string; first_name: string; last_name: string; job_title: string; status?: string };
|
|
/** Die Planstelle, die die Person heute innehat. */
|
|
type PlacementInfo = { positionNumber: string; jobTitle: string; isChief: boolean; current: boolean };
|
|
|
|
type EmployeeDetailProps = {
|
|
employee: EmployeeRow;
|
|
placement: PlacementInfo | null;
|
|
breadcrumb: string;
|
|
manager: MiniEmployee | null;
|
|
/** Nur gesetzt, wenn die zuständige Leitung abwesend ist und vertreten wird. */
|
|
formalManager: MiniEmployee | null;
|
|
directReports: MiniEmployee[];
|
|
history: HistoryRow[];
|
|
dependents: Dependent[];
|
|
notes: NoteRow[];
|
|
locations: Location[];
|
|
openPositions: OpenPositionResolved[];
|
|
};
|
|
|
|
type PanelType = "transfer" | "promote" | "karenz" | "daten" | "terminate" | "rehire" | null;
|
|
const TABS = ["Stammdaten", "Vertrag", "Organisation", "Historie", "HR-Notizen"] as const;
|
|
|
|
export function EmployeeDetail(props: EmployeeDetailProps) {
|
|
const { employee, placement, breadcrumb, manager, formalManager, directReports, history, dependents, notes, locations, openPositions } = props;
|
|
const [tab, setTab] = useState<(typeof TABS)[number]>("Stammdaten");
|
|
const [panel, setPanel] = useState<PanelType>(null);
|
|
|
|
const location = locations.find((l) => l.id === employee.location_id);
|
|
|
|
const isActive = employee.status === "Aktiv" || employee.status === "Karenz";
|
|
const canEditData = employee.status !== "Ausgetreten";
|
|
|
|
return (
|
|
<div className="flex flex-col gap-6">
|
|
<Link href="/employees" className="flex w-fit items-center gap-1.5 text-sm font-semibold text-ink-muted hover:text-ink">
|
|
<ArrowLeft className="h-4 w-4" /> Zurück zu Mitarbeiter:innen
|
|
</Link>
|
|
|
|
<div className="rounded border border-border bg-white p-6">
|
|
<div className="flex flex-wrap items-start justify-between gap-4">
|
|
<div className="flex items-start gap-4">
|
|
<Avatar firstName={employee.first_name} lastName={employee.last_name} size="lg" />
|
|
<div>
|
|
<div className="flex items-center gap-2">
|
|
<h2 className="text-xl font-extrabold text-ink">
|
|
{fmtFullName(employee.first_name, employee.last_name, employee.title_prefix, employee.title_suffix)}
|
|
</h2>
|
|
<StatusChip status={employee.status} entryDate={employee.entry_date} absenceType={employee.absence_type} />
|
|
</div>
|
|
<p className="text-sm text-ink-body">{placement?.jobTitle ?? employee.job_title}</p>
|
|
<p className="text-xs text-ink-muted">
|
|
{breadcrumb}
|
|
{placement && (
|
|
<>
|
|
{" · Planstelle "}
|
|
{placement.positionNumber}
|
|
{placement.isChief && " (Leitung)"}
|
|
</>
|
|
)}
|
|
</p>
|
|
<p className="mt-1 text-xs text-ink-muted">
|
|
Pers.-Nr. {employee.personnel_number}
|
|
{employee.status !== "Geplant" && <> · Zugehörigkeit: {tenure(employee.entry_date, employee.exit_date)}</>}
|
|
</p>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="flex flex-wrap gap-2">
|
|
{isActive && (
|
|
<>
|
|
<ActionButton icon={ArrowRightLeft} label="Versetzen" onClick={() => setPanel("transfer")} />
|
|
<ActionButton icon={TrendingUp} label="Befördern" onClick={() => setPanel("promote")} />
|
|
<ActionButton
|
|
icon={Clock}
|
|
label={employee.status === "Karenz" ? "Abwesenheit verwalten" : "Langzeitabwesenheit"}
|
|
onClick={() => setPanel("karenz")}
|
|
/>
|
|
</>
|
|
)}
|
|
{canEditData && <ActionButton icon={Pencil} label="Daten ändern" onClick={() => setPanel("daten")} />}
|
|
{isActive && (
|
|
<Button
|
|
variant="secondary"
|
|
size="sm"
|
|
onClick={() => setPanel("terminate")}
|
|
className="!border-danger-solid !text-danger-solid hover:!bg-danger-bg"
|
|
>
|
|
<XCircle className="h-4 w-4" /> Austritt
|
|
</Button>
|
|
)}
|
|
{employee.status === "Ausgetreten" && (
|
|
<Button size="sm" onClick={() => setPanel("rehire")}>
|
|
<RotateCcw className="h-4 w-4" /> Wiedereinstellen
|
|
</Button>
|
|
)}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
{/* Tabs, so the list gets the tablist role and each button says
|
|
whether it is the selected one. */}
|
|
<div role="tablist" aria-label="Mitarbeiterdetails" className="flex gap-1 overflow-x-auto border-b border-border">
|
|
{TABS.map((t) => (
|
|
<button
|
|
key={t}
|
|
role="tab"
|
|
aria-selected={tab === t}
|
|
onClick={() => setTab(t)}
|
|
className={`whitespace-nowrap border-b-2 px-4 py-2 text-sm font-semibold focus-visible:outline-2 focus-visible:outline-offset-[-2px] focus-visible:outline-brand-500 ${
|
|
tab === t ? "border-brand-500 text-brand-700" : "border-transparent text-ink-muted hover:text-ink"
|
|
}`}
|
|
>
|
|
{t === "HR-Notizen" ? `HR-Notizen ${notes.length}` : t}
|
|
</button>
|
|
))}
|
|
</div>
|
|
|
|
<div className="rounded border border-border bg-white p-6">
|
|
{tab === "Stammdaten" && <StammdatenTab employee={employee} location={location} dependents={dependents} />}
|
|
{tab === "Vertrag" && <VertragTab employee={employee} />}
|
|
{tab === "Organisation" && (
|
|
<OrganisationTab
|
|
employeeId={employee.id}
|
|
manager={manager}
|
|
formalManager={formalManager}
|
|
directReports={directReports}
|
|
breadcrumb={breadcrumb}
|
|
/>
|
|
)}
|
|
{tab === "Historie" && <HistorieTab history={history} employeeId={employee.id} />}
|
|
{tab === "HR-Notizen" && <NotizenTab employeeId={employee.id} notes={notes} />}
|
|
</div>
|
|
|
|
<TransferPanel
|
|
open={panel === "transfer"}
|
|
onClose={() => setPanel(null)}
|
|
employee={employee}
|
|
openPositions={openPositions}
|
|
/>
|
|
<PromotePanel open={panel === "promote"} onClose={() => setPanel(null)} employee={employee} />
|
|
<KarenzPanel open={panel === "karenz"} onClose={() => setPanel(null)} employee={employee} />
|
|
<DatenAendernPanel
|
|
open={panel === "daten"}
|
|
onClose={() => setPanel(null)}
|
|
employee={employee}
|
|
dependents={dependents}
|
|
locationCountry={location?.country}
|
|
/>
|
|
<TerminatePanel open={panel === "terminate"} onClose={() => setPanel(null)} employee={employee} directReportCount={directReports.length} />
|
|
<RehirePanel
|
|
open={panel === "rehire"}
|
|
onClose={() => setPanel(null)}
|
|
employee={employee}
|
|
openPositions={openPositions}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function ActionButton({ icon: Icon, label, onClick }: { icon: typeof ArrowRightLeft; label: string; onClick: () => void }) {
|
|
return (
|
|
<Button variant="secondary" size="sm" onClick={onClick}>
|
|
<Icon className="h-4 w-4" /> {label}
|
|
</Button>
|
|
);
|
|
}
|