Data model - employee_assignments records org placement over time (valid_from/valid_to), written by a trigger on `employees` rather than inside each RPC: ~70 `update employees` statements spread over fifteen migrations mean per-call bookkeeping would miss paths today and again with every future RPC. A partial unique index enforces the one-open-interval invariant the trigger relies on when closing the current row. - The Organigramm gains a Stichtag (default today). Membership comes from entry/exit/karenz, past placement from the new history, future placement projected from pending_org_changes. Placements predating the migration are backfilled with today's values and flagged as such in the UI, since employee_history only ever stored free text and cannot be reconstructed. Correctness - Reports and exports silently truncated at PostgREST's 1000-row cap (db.max_rows); employee_history is already past it at ~800 staff. Every whole-table read now pages explicitly. - XLSX date cells were a day early: ExcelJS converts a Date to an Excel serial straight off getTime(), so a Date built at local midnight lands on the previous day's serial in any positive-offset zone. - Date handling is pinned to Europe/Vienna throughout, and date-only strings are formatted without a Date round-trip. The dashboard's YTD window was built by round-tripping a local Date through toISOString(), which shifted it a day early and dropped 31 December entirely. - Export routes parsed measure/group/split/eventType with unchecked `as` casts, so an unknown value reached column headers as `undefined` and the Content-Disposition filename. Parsed against the label maps now, with the filename slugged as a backstop. - toXlsx keyed columns by header text, silently dropping the second of any two columns sharing a name — split columns take their header from data. - The org chart tree walks had no cycle guard; nothing in the schema forbids a manager_id cycle, and one would hang the tab rather than misreport. - The login page reflected ?error= verbatim, letting anyone put arbitrary text on the real sign-in screen; messages are looked up by code now. - React Flow needs elementsSelectable on, or it sets pointer-events:none on the whole node and the expand control stops responding. UI - Mobile: the shell was unusable below lg — a fixed 236px margin pushed content off-screen with no mobile navigation at all. The sidebar is now a drawer, dvh replaces vh, safe-area insets are honoured, inputs are 16px so iOS stops zooming on focus, and form grids stack. - Org chart nodes redesigned: per-kind accent stripes and icons, vacant roles called out, expand control moved to the bottom edge carrying the child count. - Pagination is windowed; it previously rendered one link per page (54 for the employee list, unbounded for the audit log). - Positions page reduced to open positions with a single "Besetzen" action. - The employee Organisation tab links into the org chart focused on that person, reusing the chart's existing search-match highlighting. Also included, uncommitted until now - Dependants, HR notes, academic titles, split address fields, position validity and role/employment fields, with their migrations and UI. - Docker/compose deployment setup, data-model and security-review docs.
76 lines
3.0 KiB
TypeScript
76 lines
3.0 KiB
TypeScript
import { X } from "lucide-react";
|
||
import { Lookup } from "@/components/ui/Lookup";
|
||
import { fmtDate } from "@/lib/format";
|
||
import type { OpenPositionResolved } from "@/lib/positions";
|
||
import type { HireDraftData } from "./types";
|
||
|
||
type StepPositionProps = {
|
||
draft: HireDraftData;
|
||
update: (patch: Partial<HireDraftData>) => void;
|
||
openPositions: OpenPositionResolved[];
|
||
};
|
||
|
||
export function StepPosition({ draft, update, openPositions }: StepPositionProps) {
|
||
const selected = openPositions.find((p) => p.id === draft.positionId) ?? null;
|
||
|
||
async function search(query: string): Promise<OpenPositionResolved[]> {
|
||
const q = query.toLowerCase();
|
||
return openPositions.filter((p) => p.title.toLowerCase().includes(q) || p.position_number.includes(q));
|
||
}
|
||
|
||
return (
|
||
<div className="flex flex-col gap-4">
|
||
<div>
|
||
<label className="mb-1 block text-sm font-semibold text-ink">Position*</label>
|
||
{!selected ? (
|
||
<Lookup<OpenPositionResolved>
|
||
placeholder="Positionsname oder -nummer…"
|
||
onSearch={search}
|
||
onSelect={(p) => update({ positionId: p.id })}
|
||
renderResult={(p) => (
|
||
<div>
|
||
<div className="font-semibold text-ink">{p.title}</div>
|
||
<div className="text-xs text-ink-muted">
|
||
{p.position_number} · {p.orgLabel}
|
||
</div>
|
||
</div>
|
||
)}
|
||
/>
|
||
) : (
|
||
<div className="flex items-center justify-between rounded border border-border bg-surface p-3">
|
||
<div>
|
||
<div className="text-sm font-semibold text-ink">{selected.title}</div>
|
||
<div className="text-xs text-ink-muted">
|
||
{selected.position_number} · {selected.orgLabel}
|
||
</div>
|
||
<div className="text-xs text-ink-muted">Gültig ab {fmtDate(selected.valid_from)}</div>
|
||
</div>
|
||
<button type="button" onClick={() => update({ positionId: "" })} aria-label="Auswahl aufheben">
|
||
<X className="h-4 w-4 text-ink-muted" />
|
||
</button>
|
||
</div>
|
||
)}
|
||
{openPositions.length === 0 && <p className="mt-1 text-xs text-ink-muted">Derzeit sind keine offenen Positionen vorhanden.</p>}
|
||
</div>
|
||
|
||
<div>
|
||
<label className="mb-1 block text-sm font-semibold text-ink">Besetzung*</label>
|
||
<select
|
||
value={draft.besetzung}
|
||
onChange={(e) => update({ besetzung: e.target.value as HireDraftData["besetzung"] })}
|
||
className="w-full rounded border border-border px-3 py-2 text-sm"
|
||
>
|
||
<option value="">Bitte wählen…</option>
|
||
<option value="Extern">Extern</option>
|
||
<option value="Intern">Intern</option>
|
||
</select>
|
||
</div>
|
||
|
||
<div>
|
||
<label className="mb-1 block text-sm font-semibold text-ink">Führungskraft</label>
|
||
<input value={selected?.managerName ?? "–"} disabled className="w-full rounded border border-border bg-surface px-3 py-2 text-sm text-ink-muted" />
|
||
</div>
|
||
</div>
|
||
);
|
||
}
|