Data model - employee_assignments records org placement over time (valid_from/valid_to), written by a trigger on `employees` rather than inside each RPC: ~70 `update employees` statements spread over fifteen migrations mean per-call bookkeeping would miss paths today and again with every future RPC. A partial unique index enforces the one-open-interval invariant the trigger relies on when closing the current row. - The Organigramm gains a Stichtag (default today). Membership comes from entry/exit/karenz, past placement from the new history, future placement projected from pending_org_changes. Placements predating the migration are backfilled with today's values and flagged as such in the UI, since employee_history only ever stored free text and cannot be reconstructed. Correctness - Reports and exports silently truncated at PostgREST's 1000-row cap (db.max_rows); employee_history is already past it at ~800 staff. Every whole-table read now pages explicitly. - XLSX date cells were a day early: ExcelJS converts a Date to an Excel serial straight off getTime(), so a Date built at local midnight lands on the previous day's serial in any positive-offset zone. - Date handling is pinned to Europe/Vienna throughout, and date-only strings are formatted without a Date round-trip. The dashboard's YTD window was built by round-tripping a local Date through toISOString(), which shifted it a day early and dropped 31 December entirely. - Export routes parsed measure/group/split/eventType with unchecked `as` casts, so an unknown value reached column headers as `undefined` and the Content-Disposition filename. Parsed against the label maps now, with the filename slugged as a backstop. - toXlsx keyed columns by header text, silently dropping the second of any two columns sharing a name — split columns take their header from data. - The org chart tree walks had no cycle guard; nothing in the schema forbids a manager_id cycle, and one would hang the tab rather than misreport. - The login page reflected ?error= verbatim, letting anyone put arbitrary text on the real sign-in screen; messages are looked up by code now. - React Flow needs elementsSelectable on, or it sets pointer-events:none on the whole node and the expand control stops responding. UI - Mobile: the shell was unusable below lg — a fixed 236px margin pushed content off-screen with no mobile navigation at all. The sidebar is now a drawer, dvh replaces vh, safe-area insets are honoured, inputs are 16px so iOS stops zooming on focus, and form grids stack. - Org chart nodes redesigned: per-kind accent stripes and icons, vacant roles called out, expand control moved to the bottom edge carrying the child count. - Pagination is windowed; it previously rendered one link per page (54 for the employee list, unbounded for the audit log). - Positions page reduced to open positions with a single "Besetzen" action. - The employee Organisation tab links into the org chart focused on that person, reusing the chart's existing search-match highlighting. Also included, uncommitted until now - Dependants, HR notes, academic titles, split address fields, position validity and role/employment fields, with their migrations and UI. - Docker/compose deployment setup, data-model and security-review docs.
157 lines
6.0 KiB
TypeScript
157 lines
6.0 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { afterAll, beforeAll, describe, expect, it } from "vitest";
|
|
import {
|
|
adminClient,
|
|
createHrUser,
|
|
createTestPosition,
|
|
deleteTestEmployee,
|
|
deleteTestPosition,
|
|
deleteTestUser,
|
|
hireTestEmployee,
|
|
isoDateOffset,
|
|
pickSeededLocation,
|
|
pickSeededTeam,
|
|
signInAs,
|
|
teamLeadId,
|
|
type TestUser,
|
|
} from "./helpers";
|
|
import type { SupabaseClient } from "@supabase/supabase-js";
|
|
import type { Database } from "@/lib/supabase/types";
|
|
|
|
// Position validity window + delete (supabase/migrations/20260716120000_position_validity_and_delete.sql):
|
|
// positions now carry a required valid_from ("gültig ab") date, an open
|
|
// position can be deleted again, and neither internal staffing nor an
|
|
// external hire may assign an employee to a position before that date.
|
|
describe("position validity and delete", () => {
|
|
let hrUser: TestUser;
|
|
let hrClient: SupabaseClient<Database>;
|
|
let teamA: { id: string };
|
|
let superiorId: string;
|
|
const positionIds: string[] = [];
|
|
const employeeIds: string[] = [];
|
|
|
|
beforeAll(async () => {
|
|
hrUser = await createHrUser({ active: true });
|
|
hrClient = await signInAs(hrUser);
|
|
teamA = await pickSeededTeam();
|
|
superiorId = (await teamLeadId(teamA.id))!;
|
|
});
|
|
|
|
afterAll(async () => {
|
|
// Positions first: reports_to_employee_id / filled_by_employee_id
|
|
// reference employees(id) with no cascade.
|
|
for (const id of positionIds) await deleteTestPosition(id);
|
|
for (const id of employeeIds) await deleteTestEmployee(id);
|
|
await deleteTestUser(hrUser);
|
|
});
|
|
|
|
it("create_position records the given valid_from", async () => {
|
|
const validFrom = isoDateOffset(10);
|
|
const positionId = await createTestPosition(hrClient, superiorId, { valid_from: validFrom });
|
|
positionIds.push(positionId);
|
|
|
|
const { data } = await adminClient.from("positions").select("valid_from").eq("id", positionId).single();
|
|
expect(data?.valid_from).toBe(validFrom);
|
|
});
|
|
|
|
it("create_position defaults valid_from to today when omitted", async () => {
|
|
const positionId = await createTestPosition(hrClient, superiorId);
|
|
positionIds.push(positionId);
|
|
|
|
const { data } = await adminClient.from("positions").select("valid_from").eq("id", positionId).single();
|
|
expect(data?.valid_from).toBe(isoDateOffset(0));
|
|
});
|
|
|
|
it("delete_position removes an open position", async () => {
|
|
const positionId = await createTestPosition(hrClient, superiorId);
|
|
|
|
const { error } = await hrClient.rpc("delete_position", { payload: { position_id: positionId } });
|
|
expect(error).toBeNull();
|
|
|
|
const { data } = await adminClient.from("positions").select("id").eq("id", positionId).maybeSingle();
|
|
expect(data).toBeNull();
|
|
});
|
|
|
|
it("delete_position rejects a filled position", async () => {
|
|
const positionId = await createTestPosition(hrClient, superiorId, { valid_from: isoDateOffset(-10) });
|
|
positionIds.push(positionId);
|
|
const employeeId = await hireTestEmployee(hrClient, teamA.id);
|
|
employeeIds.push(employeeId);
|
|
|
|
const { error: staffError } = await hrClient.rpc("staff_position_internally", {
|
|
payload: { position_id: positionId, employee_id: employeeId },
|
|
});
|
|
expect(staffError).toBeNull();
|
|
|
|
const { error } = await hrClient.rpc("delete_position", { payload: { position_id: positionId } });
|
|
expect(error?.message).toMatch(/Nur offene Positionen können gelöscht werden/);
|
|
});
|
|
|
|
it("staff_position_internally rejects assigning to a position before its valid_from", async () => {
|
|
const positionId = await createTestPosition(hrClient, superiorId, { valid_from: isoDateOffset(10) });
|
|
positionIds.push(positionId);
|
|
const employeeId = await hireTestEmployee(hrClient, teamA.id);
|
|
employeeIds.push(employeeId);
|
|
|
|
const { error } = await hrClient.rpc("staff_position_internally", {
|
|
payload: { position_id: positionId, employee_id: employeeId },
|
|
});
|
|
expect(error?.message).toMatch(/erst ab .* gültig/);
|
|
});
|
|
|
|
it("staff_position_internally accepts assigning to a position on/after its valid_from", async () => {
|
|
const positionId = await createTestPosition(hrClient, superiorId, { valid_from: isoDateOffset(-1) });
|
|
positionIds.push(positionId);
|
|
const employeeId = await hireTestEmployee(hrClient, teamA.id);
|
|
employeeIds.push(employeeId);
|
|
|
|
const { error } = await hrClient.rpc("staff_position_internally", {
|
|
payload: { position_id: positionId, employee_id: employeeId },
|
|
});
|
|
expect(error).toBeNull();
|
|
});
|
|
|
|
it("hire_employee rejects an entry_date before the position's valid_from", async () => {
|
|
const validFrom = isoDateOffset(10);
|
|
const positionId = await createTestPosition(hrClient, superiorId, { valid_from: validFrom });
|
|
positionIds.push(positionId);
|
|
const location = await pickSeededLocation();
|
|
|
|
const { error } = await hrClient.rpc("hire_employee", {
|
|
payload: {
|
|
first_name: "Integrationstest",
|
|
last_name: `Person-${randomUUID().slice(0, 8)}`,
|
|
gender: "w",
|
|
birth_date: "1990-01-01",
|
|
location_id: location.id,
|
|
position_id: positionId,
|
|
entry_date: isoDateOffset(5),
|
|
source: "Extern",
|
|
},
|
|
});
|
|
expect(error?.message).toMatch(/Eintrittsdatum darf nicht vor dem Gültigkeitsbeginn/);
|
|
});
|
|
|
|
it("hire_employee accepts an entry_date on/after the position's valid_from", async () => {
|
|
const validFrom = isoDateOffset(10);
|
|
const positionId = await createTestPosition(hrClient, superiorId, { valid_from: validFrom });
|
|
positionIds.push(positionId);
|
|
const location = await pickSeededLocation();
|
|
|
|
const { data, error } = await hrClient.rpc("hire_employee", {
|
|
payload: {
|
|
first_name: "Integrationstest",
|
|
last_name: `Person-${randomUUID().slice(0, 8)}`,
|
|
gender: "w",
|
|
birth_date: "1990-01-01",
|
|
location_id: location.id,
|
|
position_id: positionId,
|
|
entry_date: validFrom,
|
|
source: "Extern",
|
|
},
|
|
});
|
|
expect(error).toBeNull();
|
|
if (data) employeeIds.push(data);
|
|
});
|
|
});
|