Accessibility work on the UI layer, all of it rooted in one structural gap: there were no form primitives, so every field was hand-assembled and every field got the same details wrong. Form primitives - components/ui/Field.tsx (Field/TextField/SelectField/TextareaField) and Button.tsx. Field generates the control id with useId and derives htmlFor from it, which is what makes the association impossible to omit rather than merely conventional. - 92 labels existed, 4 used htmlFor, and no input carried an id at all: a screen reader announced an unnamed edit box and clicking a label focused nothing. Now every label resolves to its control (0 unassociated), and the input class chain that appeared verbatim 85 times appears zero times. - Field also takes a render prop, so Lookup, CountryPicker and Picklist get the same wiring instead of a second, partial solution. - SearchInput replaces three hand-rolled copies of the icon-in-a-box search whose input had only a placeholder — not a label — and killed its own focus ring with outline-none and nothing in its place. - Toggle groups (workdays, reorg change type) became fieldsets with aria-pressed; colour alone was carrying the selected state. Comboboxes - Lookup and CountryPicker were text inputs with a div of clickable buttons underneath: typeable, but no keyboard path to a result and nothing telling a screen reader a list had appeared. Both now carry role=combobox, aria-expanded/controls/activedescendant and listbox semantics, with arrow keys, Enter and Escape. Escape stops propagation, or it would close the surrounding dialog along with the dropdown. Dialogs - useDialogFocus centralises what Modal and SlideOver each owed the keyboard and neither provided beyond Escape: focus into the dialog on open, Tab and Shift+Tab cycling within it, focus restored to the trigger on close. - SlideOver stays mounted for its transition, and aria-hidden does not remove anything from the tab order — so every closed panel was leaving invisible tab stops at the end of the page. `inert` fixes that. Route states - loading.tsx, error.tsx, not-found.tsx and global-error.tsx. Every page in the (app) group is server-rendered per request, so without loading.tsx a navigation showed nothing at all until the server answered, and a render error dropped the user on Next's own screen with no way back. Tests - 22 component tests (vitest jsdom project). Two of them found limits of the environment rather than of the code: jsdom implements neither `inert` nor scrollIntoView, so the inert test asserts the attribute and the missing scrollIntoView — which was taking the whole render down from inside an effect — is stubbed in the setup file.
111 lines
3.6 KiB
TypeScript
111 lines
3.6 KiB
TypeScript
"use client";
|
|
|
|
import { useRouter } from "next/navigation";
|
|
import { useMemo, useState } from "react";
|
|
import { transferEmployee } from "@/actions/employees";
|
|
import { Button } from "@/components/ui/Button";
|
|
import { SelectField, TextField } from "@/components/ui/Field";
|
|
import { SlideOver } from "@/components/ui/SlideOver";
|
|
import { useToast } from "@/components/ui/Toast";
|
|
import type { Database } from "@/lib/supabase/types";
|
|
|
|
type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
|
|
type Division = Database["public"]["Tables"]["divisions"]["Row"];
|
|
type Department = Database["public"]["Tables"]["departments"]["Row"];
|
|
type Team = Database["public"]["Tables"]["teams"]["Row"];
|
|
|
|
type TransferPanelProps = {
|
|
open: boolean;
|
|
onClose: () => void;
|
|
employee: EmployeeRow;
|
|
divisions: Division[];
|
|
departments: Department[];
|
|
teams: Team[];
|
|
currentTeamId: string | null;
|
|
};
|
|
|
|
export function TransferPanel({ open, onClose, employee, divisions, departments, teams, currentTeamId }: TransferPanelProps) {
|
|
const { showToast } = useToast();
|
|
const router = useRouter();
|
|
const [effectiveDate, setEffectiveDate] = useState("");
|
|
const [divisionId, setDivisionId] = useState(employee.division_id);
|
|
const [teamId, setTeamId] = useState(currentTeamId ?? "");
|
|
const [newTitle, setNewTitle] = useState("");
|
|
const [pending, setPending] = useState(false);
|
|
|
|
const teamsInDivision = useMemo(() => {
|
|
const deptIds = new Set(departments.filter((d) => d.division_id === divisionId).map((d) => d.id));
|
|
return teams.filter((t) => deptIds.has(t.department_id));
|
|
}, [departments, teams, divisionId]);
|
|
|
|
async function handleSubmit() {
|
|
if (!effectiveDate || !teamId) {
|
|
showToast("Bitte Datum und Zielteam angeben.", "error");
|
|
return;
|
|
}
|
|
setPending(true);
|
|
const result = await transferEmployee({
|
|
employee_id: employee.id,
|
|
effective_date: effectiveDate,
|
|
new_team_id: teamId,
|
|
new_title: newTitle || undefined,
|
|
});
|
|
setPending(false);
|
|
if (result.success) {
|
|
showToast(`${employee.first_name} ${employee.last_name} wurde versetzt.`);
|
|
router.refresh();
|
|
onClose();
|
|
} else {
|
|
showToast(result.error ?? "Fehler beim Speichern.", "error");
|
|
}
|
|
}
|
|
|
|
return (
|
|
<SlideOver
|
|
open={open}
|
|
onClose={onClose}
|
|
title="Versetzung"
|
|
subtitle={`${employee.first_name} ${employee.last_name} · ${employee.job_title}`}
|
|
footer={
|
|
<>
|
|
<Button variant="ghost" onClick={onClose}>
|
|
Abbrechen
|
|
</Button>
|
|
<Button onClick={handleSubmit} pending={pending}>
|
|
Versetzen
|
|
</Button>
|
|
</>
|
|
}
|
|
>
|
|
<div className="flex flex-col gap-4">
|
|
<TextField label="Wirksam ab" required type="date" value={effectiveDate} onChange={setEffectiveDate} />
|
|
<SelectField
|
|
label="Neuer Bereich"
|
|
required
|
|
value={divisionId}
|
|
onChange={(v) => {
|
|
setDivisionId(v);
|
|
setTeamId("");
|
|
}}
|
|
options={divisions.map((d) => ({ value: d.id, label: d.name }))}
|
|
/>
|
|
<SelectField
|
|
label="Neues Team"
|
|
required
|
|
value={teamId}
|
|
onChange={setTeamId}
|
|
placeholder="Bitte wählen…"
|
|
options={teamsInDivision.map((t) => ({ value: t.id, label: t.name }))}
|
|
/>
|
|
<TextField
|
|
label="Neuer Titel (optional)"
|
|
value={newTitle}
|
|
onChange={setNewTitle}
|
|
placeholder={employee.job_title}
|
|
hint="Die neue Führungskraft wird automatisch anhand des Zielteams bestimmt."
|
|
/>
|
|
</div>
|
|
</SlideOver>
|
|
);
|
|
}
|