Data model - employee_assignments records org placement over time (valid_from/valid_to), written by a trigger on `employees` rather than inside each RPC: ~70 `update employees` statements spread over fifteen migrations mean per-call bookkeeping would miss paths today and again with every future RPC. A partial unique index enforces the one-open-interval invariant the trigger relies on when closing the current row. - The Organigramm gains a Stichtag (default today). Membership comes from entry/exit/karenz, past placement from the new history, future placement projected from pending_org_changes. Placements predating the migration are backfilled with today's values and flagged as such in the UI, since employee_history only ever stored free text and cannot be reconstructed. Correctness - Reports and exports silently truncated at PostgREST's 1000-row cap (db.max_rows); employee_history is already past it at ~800 staff. Every whole-table read now pages explicitly. - XLSX date cells were a day early: ExcelJS converts a Date to an Excel serial straight off getTime(), so a Date built at local midnight lands on the previous day's serial in any positive-offset zone. - Date handling is pinned to Europe/Vienna throughout, and date-only strings are formatted without a Date round-trip. The dashboard's YTD window was built by round-tripping a local Date through toISOString(), which shifted it a day early and dropped 31 December entirely. - Export routes parsed measure/group/split/eventType with unchecked `as` casts, so an unknown value reached column headers as `undefined` and the Content-Disposition filename. Parsed against the label maps now, with the filename slugged as a backstop. - toXlsx keyed columns by header text, silently dropping the second of any two columns sharing a name — split columns take their header from data. - The org chart tree walks had no cycle guard; nothing in the schema forbids a manager_id cycle, and one would hang the tab rather than misreport. - The login page reflected ?error= verbatim, letting anyone put arbitrary text on the real sign-in screen; messages are looked up by code now. - React Flow needs elementsSelectable on, or it sets pointer-events:none on the whole node and the expand control stops responding. UI - Mobile: the shell was unusable below lg — a fixed 236px margin pushed content off-screen with no mobile navigation at all. The sidebar is now a drawer, dvh replaces vh, safe-area insets are honoured, inputs are 16px so iOS stops zooming on focus, and form grids stack. - Org chart nodes redesigned: per-kind accent stripes and icons, vacant roles called out, expand control moved to the bottom edge carrying the child count. - Pagination is windowed; it previously rendered one link per page (54 for the employee list, unbounded for the audit log). - Positions page reduced to open positions with a single "Besetzen" action. - The employee Organisation tab links into the org chart focused on that person, reusing the chart's existing search-match highlighting. Also included, uncommitted until now - Dependants, HR notes, academic titles, split address fields, position validity and role/employment fields, with their migrations and UI. - Docker/compose deployment setup, data-model and security-review docs.
203 lines
8.3 KiB
TypeScript
203 lines
8.3 KiB
TypeScript
"use client";
|
|
|
|
import { ChevronDown, ChevronRight, Search } from "lucide-react";
|
|
import Link from "next/link";
|
|
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
|
|
import { Avatar } from "@/components/ui/Avatar";
|
|
import { SegmentedControl } from "@/components/ui/SegmentedControl";
|
|
import { LazyGraphOrgChart } from "./LazyGraphOrgChart";
|
|
import type { ChartNode, OrgEmployee } from "./types";
|
|
|
|
type ViewMode = "list" | "graph";
|
|
|
|
export function EmployeeTree({ employees, focusId = null }: { employees: OrgEmployee[]; focusId?: string | null }) {
|
|
// Seeded with the focus target so their own reports are already unfolded;
|
|
// the chain *above* them comes from ancestorExpandIds.
|
|
const [expanded, setExpanded] = useState<Set<string>>(() => (focusId ? new Set([focusId]) : new Set()));
|
|
const [query, setQuery] = useState("");
|
|
const [mode, setMode] = useState<ViewMode>("list");
|
|
const focusRef = useRef<HTMLDivElement>(null);
|
|
|
|
const { childrenByManager, totalReportsById, root } = useMemo(() => {
|
|
const byManager = new Map<string, OrgEmployee[]>();
|
|
for (const e of employees) {
|
|
const key = e.manager_id ?? "__root__";
|
|
if (!byManager.has(key)) byManager.set(key, []);
|
|
byManager.get(key)!.push(e);
|
|
}
|
|
for (const list of byManager.values()) list.sort((a, b) => a.last_name.localeCompare(b.last_name));
|
|
|
|
// Nothing in the schema forbids a manager_id cycle (A reports to B
|
|
// reports to A), and a reorg that moves a lead under one of their own
|
|
// reports would create one. Every walk below is recursive, so an
|
|
// unguarded cycle is an infinite recursion that hangs the tab rather
|
|
// than a wrong number — hence the on-path set.
|
|
const totals = new Map<string, number>();
|
|
function countTotal(id: string, path: Set<string>): number {
|
|
const memo = totals.get(id);
|
|
if (memo !== undefined) return memo;
|
|
if (path.has(id)) return 0;
|
|
path.add(id);
|
|
let total = 0;
|
|
for (const child of byManager.get(id) ?? []) total += 1 + countTotal(child.id, path);
|
|
path.delete(id);
|
|
totals.set(id, total);
|
|
return total;
|
|
}
|
|
for (const e of employees) countTotal(e.id, new Set());
|
|
|
|
return { childrenByManager: byManager, totalReportsById: totals, root: byManager.get("__root__") ?? [] };
|
|
}, [employees]);
|
|
|
|
const matchIds = useMemo(() => {
|
|
// A focus target behaves exactly like a search hit — same ancestor
|
|
// auto-expand, same ring, same fitView in graph mode — until the user
|
|
// starts typing, at which point their own search takes over.
|
|
if (query.trim().length < 2) return focusId ? new Set([focusId]) : null;
|
|
const q = query.trim().toLowerCase();
|
|
const matches = new Set<string>();
|
|
for (const e of employees) {
|
|
if (
|
|
`${e.first_name} ${e.last_name}`.toLowerCase().includes(q) ||
|
|
e.job_title.toLowerCase().includes(q) ||
|
|
String(e.personnel_number).includes(q)
|
|
) {
|
|
matches.add(e.id);
|
|
}
|
|
}
|
|
return matches;
|
|
}, [query, employees, focusId]);
|
|
|
|
// The chain above the focused person is auto-expanded, so the row only
|
|
// exists after that render — scroll once it does.
|
|
useEffect(() => {
|
|
if (!focusId) return;
|
|
focusRef.current?.scrollIntoView({ block: "center", behavior: "smooth" });
|
|
}, [focusId, mode]);
|
|
|
|
const ancestorExpandIds = useMemo(() => {
|
|
if (!matchIds) return null;
|
|
const byId = new Map(employees.map((e) => [e.id, e]));
|
|
const toExpand = new Set<string>();
|
|
for (const id of matchIds) {
|
|
let current = byId.get(id);
|
|
while (current?.manager_id && !toExpand.has(current.manager_id)) {
|
|
toExpand.add(current.manager_id);
|
|
current = byId.get(current.manager_id);
|
|
}
|
|
}
|
|
return toExpand;
|
|
}, [matchIds, employees]);
|
|
|
|
// useCallback-stable: GraphOrgChart's layout memo depends on this
|
|
// reference, so an unstable function would force a Dagre re-layout on
|
|
// every unrelated re-render.
|
|
const toggle = useCallback((id: string) => {
|
|
setExpanded((prev) => {
|
|
const next = new Set(prev);
|
|
if (next.has(id)) next.delete(id);
|
|
else next.add(id);
|
|
return next;
|
|
});
|
|
}, []);
|
|
|
|
const isExpanded = useCallback((id: string): boolean => expanded.has(id) || (ancestorExpandIds?.has(id) ?? false), [expanded, ancestorExpandIds]);
|
|
|
|
const chartTree = useMemo<ChartNode[]>(() => {
|
|
function toChartNode(e: OrgEmployee, ancestors: Set<string>): ChartNode {
|
|
const children = ancestors.has(e.id) ? [] : (childrenByManager.get(e.id) ?? []);
|
|
const total = totalReportsById.get(e.id) ?? 0;
|
|
const nextAncestors = new Set(ancestors).add(e.id);
|
|
return {
|
|
id: e.id,
|
|
kind: "person",
|
|
label: `${e.first_name} ${e.last_name}`,
|
|
sublabel: e.job_title,
|
|
href: `/employees/${e.id}`,
|
|
avatar: { firstName: e.first_name, lastName: e.last_name },
|
|
totalReports: total,
|
|
matched: matchIds?.has(e.id) ?? false,
|
|
children: children.map((c) => toChartNode(c, nextAncestors)),
|
|
};
|
|
}
|
|
return root.map((r) => toChartNode(r, new Set()));
|
|
}, [root, childrenByManager, totalReportsById, matchIds]);
|
|
|
|
function renderNode(e: OrgEmployee, depth: number, ancestors: Set<string>) {
|
|
const children = ancestors.has(e.id) ? [] : (childrenByManager.get(e.id) ?? []);
|
|
const hasChildren = children.length > 0;
|
|
const expandedNow = isExpanded(e.id);
|
|
const isMatch = matchIds?.has(e.id) ?? false;
|
|
const totalReports = totalReportsById.get(e.id) ?? 0;
|
|
|
|
return (
|
|
<div key={e.id}>
|
|
<div
|
|
ref={e.id === focusId ? focusRef : undefined}
|
|
className={`flex items-center gap-2 rounded px-2 py-1.5 hover:bg-surface ${isMatch ? "bg-brand-100" : ""}`}
|
|
style={{ paddingLeft: depth * 24 + 8 }}
|
|
>
|
|
{hasChildren ? (
|
|
<button type="button" onClick={() => toggle(e.id)} className="shrink-0 text-ink-muted">
|
|
{expandedNow ? <ChevronDown className="h-4 w-4" /> : <ChevronRight className="h-4 w-4" />}
|
|
</button>
|
|
) : (
|
|
<span className="w-4 shrink-0" />
|
|
)}
|
|
<Avatar firstName={e.first_name} lastName={e.last_name} size="sm" />
|
|
<Link href={`/employees/${e.id}`} className="flex-1 hover:underline">
|
|
<span className="text-sm font-semibold text-ink">
|
|
{e.first_name} {e.last_name}
|
|
</span>
|
|
<span className="ml-2 text-xs text-ink-muted">{e.job_title}</span>
|
|
</Link>
|
|
{hasChildren && (
|
|
<span className="shrink-0 text-xs text-ink-muted">
|
|
{children.length} direkt · {totalReports} gesamt
|
|
</span>
|
|
)}
|
|
</div>
|
|
{hasChildren && expandedNow && (
|
|
<div>{children.map((c) => renderNode(c, depth + 1, new Set(ancestors).add(e.id)))}</div>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="rounded border border-border bg-white p-4">
|
|
<div className="mb-4 flex flex-wrap items-center gap-3">
|
|
<div className="flex min-w-[240px] flex-1 items-center gap-2 rounded border border-border px-3 py-2">
|
|
<Search className="h-4 w-4 shrink-0 text-ink-muted" />
|
|
<input
|
|
value={query}
|
|
onChange={(e) => setQuery(e.target.value)}
|
|
placeholder="Name, Pers.-Nr., Titel…"
|
|
className="w-full text-sm text-ink outline-none placeholder:text-ink-muted"
|
|
/>
|
|
</div>
|
|
<button
|
|
type="button"
|
|
onClick={() => setExpanded(new Set(root.map((r) => r.id)))}
|
|
className="rounded border border-border px-3 py-1.5 text-sm font-semibold text-ink-body hover:bg-surface"
|
|
>
|
|
Bereiche anzeigen
|
|
</button>
|
|
<button
|
|
type="button"
|
|
onClick={() => setExpanded(new Set())}
|
|
className="rounded border border-border px-3 py-1.5 text-sm font-semibold text-ink-body hover:bg-surface"
|
|
>
|
|
Alles einklappen
|
|
</button>
|
|
<SegmentedControl<ViewMode> value={mode} onChange={setMode} options={[{ value: "list", label: "Liste" }, { value: "graph", label: "Grafisch" }]} />
|
|
</div>
|
|
{mode === "list" ? (
|
|
<div>{root.map((r) => renderNode(r, 0, new Set()))}</div>
|
|
) : (
|
|
<LazyGraphOrgChart tree={chartTree} isExpanded={isExpanded} onToggle={toggle} matchedIds={matchIds} />
|
|
)}
|
|
</div>
|
|
);
|
|
}
|