Maximilian Stubhan
79f0e19bf8
Data model - employee_assignments records org placement over time (valid_from/valid_to), written by a trigger on `employees` rather than inside each RPC: ~70 `update employees` statements spread over fifteen migrations mean per-call bookkeeping would miss paths today and again with every future RPC. A partial unique index enforces the one-open-interval invariant the trigger relies on when closing the current row. - The Organigramm gains a Stichtag (default today). Membership comes from entry/exit/karenz, past placement from the new history, future placement projected from pending_org_changes. Placements predating the migration are backfilled with today's values and flagged as such in the UI, since employee_history only ever stored free text and cannot be reconstructed. Correctness - Reports and exports silently truncated at PostgREST's 1000-row cap (db.max_rows); employee_history is already past it at ~800 staff. Every whole-table read now pages explicitly. - XLSX date cells were a day early: ExcelJS converts a Date to an Excel serial straight off getTime(), so a Date built at local midnight lands on the previous day's serial in any positive-offset zone. - Date handling is pinned to Europe/Vienna throughout, and date-only strings are formatted without a Date round-trip. The dashboard's YTD window was built by round-tripping a local Date through toISOString(), which shifted it a day early and dropped 31 December entirely. - Export routes parsed measure/group/split/eventType with unchecked `as` casts, so an unknown value reached column headers as `undefined` and the Content-Disposition filename. Parsed against the label maps now, with the filename slugged as a backstop. - toXlsx keyed columns by header text, silently dropping the second of any two columns sharing a name — split columns take their header from data. - The org chart tree walks had no cycle guard; nothing in the schema forbids a manager_id cycle, and one would hang the tab rather than misreport. - The login page reflected ?error= verbatim, letting anyone put arbitrary text on the real sign-in screen; messages are looked up by code now. - React Flow needs elementsSelectable on, or it sets pointer-events:none on the whole node and the expand control stops responding. UI - Mobile: the shell was unusable below lg — a fixed 236px margin pushed content off-screen with no mobile navigation at all. The sidebar is now a drawer, dvh replaces vh, safe-area insets are honoured, inputs are 16px so iOS stops zooming on focus, and form grids stack. - Org chart nodes redesigned: per-kind accent stripes and icons, vacant roles called out, expand control moved to the bottom edge carrying the child count. - Pagination is windowed; it previously rendered one link per page (54 for the employee list, unbounded for the audit log). - Positions page reduced to open positions with a single "Besetzen" action. - The employee Organisation tab links into the org chart focused on that person, reusing the chart's existing search-match highlighting. Also included, uncommitted until now - Dependants, HR notes, academic titles, split address fields, position validity and role/employment fields, with their migrations and UI. - Docker/compose deployment setup, data-model and security-review docs.
66 lines
2.7 KiB
TypeScript
66 lines
2.7 KiB
TypeScript
import { fmtDate, fmtFullName } from "@/lib/format";
|
||
import type { OpenPositionResolved } from "@/lib/positions";
|
||
import type { HireDraftData } from "./types";
|
||
|
||
const PAYGRADE_LABELS: Record<string, string> = {
|
||
A: "A – Einstieg",
|
||
B: "B – Qualifiziert",
|
||
C: "C – Erfahren",
|
||
D: "D – Spezialist:in",
|
||
E: "E – Teamleitung",
|
||
F: "F – Bereichsleitung / GF",
|
||
};
|
||
|
||
type StepSummaryProps = {
|
||
draft: HireDraftData;
|
||
selectedPosition: OpenPositionResolved | null;
|
||
locations: { id: string; name: string; country: string }[];
|
||
};
|
||
|
||
export function StepSummary({ draft, selectedPosition, locations }: StepSummaryProps) {
|
||
const location = locations.find((l) => l.id === draft.locationId);
|
||
const flags = [
|
||
draft.isBetriebsrat && "Betriebsrat",
|
||
draft.hasDienstwagen && "Dienstwagen",
|
||
draft.isLateraleFuehrung && "Laterale Führung",
|
||
draft.isCLevel && "C-Level",
|
||
].filter(Boolean);
|
||
const rows: [string, string][] = [
|
||
["Name", fmtFullName(draft.firstName, draft.lastName, draft.titlePrefix, draft.titleSuffix)],
|
||
["Geschlecht", draft.gender === "m" ? "männlich" : "weiblich"],
|
||
["Geburtsdatum", fmtDate(draft.birthDate)],
|
||
["SV-Nummer", draft.svNummer || "–"],
|
||
["E-Mail (privat)", draft.email || "–"],
|
||
["Telefon", draft.phone || "–"],
|
||
["Standort", location ? `${location.name} (${location.country})` : "–"],
|
||
["Position", selectedPosition ? `${selectedPosition.title} (${selectedPosition.position_number})` : "–"],
|
||
["Organisationseinheit", selectedPosition?.orgLabel ?? "–"],
|
||
["Führungskraft", selectedPosition?.managerName ?? "–"],
|
||
["Besetzung", draft.besetzung],
|
||
["Eintrittsdatum", fmtDate(draft.entryDate)],
|
||
["Vertragsart", draft.contractType === "befristet" ? `befristet bis ${fmtDate(draft.contractEndDate)}` : "unbefristet"],
|
||
["Beschäftigungsausmaß", `${draft.employmentType} (${draft.weeklyHours} h)`],
|
||
["Paygrade", PAYGRADE_LABELS[draft.paygrade]],
|
||
["Angestellte:r / Arbeiter:in", draft.workerType],
|
||
["Kollektivvertrag", draft.collectiveAgreement],
|
||
["Arbeitstage", draft.workDays.join(", ") || "–"],
|
||
["Merkmale", flags.length > 0 ? flags.join(", ") : "–"],
|
||
];
|
||
|
||
return (
|
||
<div className="flex flex-col gap-4">
|
||
<dl className="grid grid-cols-1 gap-x-6 gap-y-3 sm:grid-cols-2">
|
||
{rows.map(([label, value]) => (
|
||
<div key={label}>
|
||
<dt className="text-xs font-semibold uppercase tracking-wide text-ink-muted">{label}</dt>
|
||
<dd className="mt-0.5 text-sm text-ink">{value}</dd>
|
||
</div>
|
||
))}
|
||
</dl>
|
||
<p className="rounded bg-info-bg px-3 py-2 text-sm text-info-text">
|
||
Personalnummer und Firmen-E-Mail-Adresse werden automatisch vergeben.
|
||
</p>
|
||
</div>
|
||
);
|
||
}
|