Maximilian Stubhan
d9367a8ce4
Accessibility work on the UI layer, all of it rooted in one structural gap: there were no form primitives, so every field was hand-assembled and every field got the same details wrong. Form primitives - components/ui/Field.tsx (Field/TextField/SelectField/TextareaField) and Button.tsx. Field generates the control id with useId and derives htmlFor from it, which is what makes the association impossible to omit rather than merely conventional. - 92 labels existed, 4 used htmlFor, and no input carried an id at all: a screen reader announced an unnamed edit box and clicking a label focused nothing. Now every label resolves to its control (0 unassociated), and the input class chain that appeared verbatim 85 times appears zero times. - Field also takes a render prop, so Lookup, CountryPicker and Picklist get the same wiring instead of a second, partial solution. - SearchInput replaces three hand-rolled copies of the icon-in-a-box search whose input had only a placeholder — not a label — and killed its own focus ring with outline-none and nothing in its place. - Toggle groups (workdays, reorg change type) became fieldsets with aria-pressed; colour alone was carrying the selected state. Comboboxes - Lookup and CountryPicker were text inputs with a div of clickable buttons underneath: typeable, but no keyboard path to a result and nothing telling a screen reader a list had appeared. Both now carry role=combobox, aria-expanded/controls/activedescendant and listbox semantics, with arrow keys, Enter and Escape. Escape stops propagation, or it would close the surrounding dialog along with the dropdown. Dialogs - useDialogFocus centralises what Modal and SlideOver each owed the keyboard and neither provided beyond Escape: focus into the dialog on open, Tab and Shift+Tab cycling within it, focus restored to the trigger on close. - SlideOver stays mounted for its transition, and aria-hidden does not remove anything from the tab order — so every closed panel was leaving invisible tab stops at the end of the page. `inert` fixes that. Route states - loading.tsx, error.tsx, not-found.tsx and global-error.tsx. Every page in the (app) group is server-rendered per request, so without loading.tsx a navigation showed nothing at all until the server answered, and a render error dropped the user on Next's own screen with no way back. Tests - 22 component tests (vitest jsdom project). Two of them found limits of the environment rather than of the code: jsdom implements neither `inert` nor scrollIntoView, so the inert test asserts the attribute and the missing scrollIntoView — which was taking the whole render down from inside an effect — is stubbed in the setup file.
94 lines
4.2 KiB
TypeScript
94 lines
4.2 KiB
TypeScript
"use client";
|
||
|
||
import { Plus, Trash2 } from "lucide-react";
|
||
import { useRouter } from "next/navigation";
|
||
import { useState } from "react";
|
||
import { deleteEmployeeDependent } from "@/actions/employees";
|
||
import { Button } from "@/components/ui/Button";
|
||
import { useToast } from "@/components/ui/Toast";
|
||
import { fmtDate, todayIso } from "@/lib/format";
|
||
import type { Database } from "@/lib/supabase/types";
|
||
import { AddDependentModal } from "./AddDependentModal";
|
||
|
||
type Dependent = Database["public"]["Tables"]["employee_dependents"]["Row"];
|
||
|
||
// `effectiveDate` lets DatenAendernPanel embed this section and drive
|
||
// add/remove off its own "Wirksam ab" field; standalone usage (Stammdaten
|
||
// tab) omits it and defaults to today, i.e. immediate.
|
||
export function AngehoerigeSection({ employeeId, dependents, effectiveDate }: { employeeId: string; dependents: Dependent[]; effectiveDate?: string }) {
|
||
const { showToast } = useToast();
|
||
const router = useRouter();
|
||
const [modalOpen, setModalOpen] = useState(false);
|
||
const [deletingId, setDeletingId] = useState<string | null>(null);
|
||
const resolvedEffectiveDate = effectiveDate || todayIso();
|
||
|
||
async function handleDelete(dependentId: string) {
|
||
setDeletingId(dependentId);
|
||
const result = await deleteEmployeeDependent({ dependent_id: dependentId, employee_id: employeeId, effective_date: resolvedEffectiveDate });
|
||
setDeletingId(null);
|
||
if (result.success) {
|
||
showToast("Angehörige:r entfernt.");
|
||
router.refresh();
|
||
} else {
|
||
showToast(result.error ?? "Fehler beim Entfernen.", "error");
|
||
}
|
||
}
|
||
|
||
return (
|
||
<div className="border-t border-border pt-6">
|
||
<div className="mb-3 flex items-center justify-between">
|
||
<h3 className="text-xs font-bold uppercase tracking-wide text-brand-700">Angehörige</h3>
|
||
<div className="flex items-center gap-4">
|
||
<Button variant="ghost" size="sm" onClick={() => setModalOpen(true)} className="!px-1 text-brand-700 hover:!bg-transparent hover:underline">
|
||
<Plus className="h-3.5 w-3.5" /> Hinzufügen
|
||
</Button>
|
||
<span className="text-xs text-ink-muted">{dependents.length} Personen</span>
|
||
</div>
|
||
</div>
|
||
|
||
{dependents.length === 0 ? (
|
||
<p className="text-sm text-ink-muted">Keine Angehörigen hinterlegt.</p>
|
||
) : (
|
||
<div className="overflow-x-auto rounded border border-border">
|
||
<table className="w-full min-w-[600px] text-sm">
|
||
<thead>
|
||
<tr className="border-b border-border bg-brand-50 text-left text-xs font-semibold uppercase tracking-wide text-ink-muted">
|
||
<th className="px-4 py-2.5">Name</th>
|
||
<th className="px-4 py-2.5">Verhältnis</th>
|
||
<th className="px-4 py-2.5">SVNR</th>
|
||
<th className="px-4 py-2.5">Geburtsdatum</th>
|
||
<th className="px-4 py-2.5" />
|
||
</tr>
|
||
</thead>
|
||
<tbody>
|
||
{dependents.map((d) => (
|
||
<tr key={d.id} className="border-b border-border last:border-0">
|
||
<td className="px-4 py-2.5 font-semibold text-ink">
|
||
{d.first_name} {d.last_name}
|
||
</td>
|
||
<td className="px-4 py-2.5 text-ink-body">{d.relationship}</td>
|
||
<td className="px-4 py-2.5 text-ink-body">{d.sv_nummer ?? "–"}</td>
|
||
<td className="px-4 py-2.5 text-ink-body">{fmtDate(d.birth_date)}</td>
|
||
<td className="px-4 py-2.5 text-right">
|
||
<Button
|
||
variant="icon"
|
||
onClick={() => handleDelete(d.id)}
|
||
pending={deletingId === d.id}
|
||
aria-label={`${d.first_name} ${d.last_name} als Angehörige:n entfernen`}
|
||
className="hover:!text-danger-solid"
|
||
>
|
||
<Trash2 className="h-3.5 w-3.5" />
|
||
</Button>
|
||
</td>
|
||
</tr>
|
||
))}
|
||
</tbody>
|
||
</table>
|
||
</div>
|
||
)}
|
||
|
||
<AddDependentModal open={modalOpen} onClose={() => setModalOpen(false)} employeeId={employeeId} defaultEffectiveDate={resolvedEffectiveDate} />
|
||
</div>
|
||
);
|
||
}
|