Maximilian Stubhan
b87c8ad64c
The database moved to a container of our own; the platform is gone. This takes out what was left of it — and, where the leftovers were load bearing, moves rather than deletes. Moved, not deleted: supabase/migrations/ -> db/migrations/ the schema's source of truth supabase/build-org.ts -> scripts/build-org.ts lib/supabase/types.ts -> lib/types.ts 52 import sites repointed The bookkeeping needed care. It lived in `supabase_migrations.schema_migrations`, and simply renaming the schema would have left the runner facing an empty table: it would have called all 67 migrations pending and replayed them against a database that is long since current. So the runner now creates `migrationen.schema_migrations` and, once, copies the old rows across — guarded so a second run does nothing and a fresh database skips it entirely. Only then does migration 20260907100000 drop the old schema. Deleted: the CLI config, the seed, the historical schema/function dumps (nothing read them), scripts/umzug-von-supabase.sh (the move is done), and both Supabase packages plus the CLI. Nothing in the application imported them — the build now succeeds with no environment variables at all, which is the proof. Integration tests: six of them signed in through Supabase Auth and asserted against the anon key and the service role. That model is gone, so the tests were not portable — they are deleted. session-context and employee-status-filter already ran on pg and are untouched; om-reporting is ported to a direct connection because it guards a real risk (the reporting line rule exists twice, once in SQL and once in TypeScript). CI: the integration job started a Supabase stack. It now runs a postgres service, applies deploy/db-init and every migration to an empty database — that was the valuable part, and it still holds — then checks that a second run is a no-op, which is what proves the bookkeeping works. Docs: security-review.md audited a service-role key, a cookie adapter and auth.users, none of which exist. Restating findings about removed components would suggest today's system had been reviewed; it has not. It now records what was removed and says a fresh review is due. data-model.md was already marked obsolete and described the pre-OM schema; azure-migration.md was a plan for a route not taken. Both deleted. Verified: npm ci, typecheck, lint, 445 tests, build — all clean without the packages. Integration tests skip cleanly with no database. Migration SQL and the runner are reviewed but NOT executed: no Docker here, and the old instance no longer resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
60 lines
2.6 KiB
PL/PgSQL
60 lines
2.6 KiB
PL/PgSQL
-- Make reorg undo respect employee_history's append-only contract
|
|
-- (spec §6.1: "append-only, keine normale
|
|
-- Update-/Delete-Funktion").
|
|
--
|
|
-- The previous undo_reorg deleted the employee_history rows a reorg had
|
|
-- created (functions.sql:549), which required a narrow RLS carve-out
|
|
-- (functions_3.sql's "history_delete_admin_reorg_undo" policy) allowing
|
|
-- hr_admin to delete reorg-tagged history rows. That is the one place in
|
|
-- the whole schema where history was not actually immutable. Fixed by
|
|
-- appending a compensating "Reorganisation rückgängig" history entry per
|
|
-- affected employee instead of deleting anything — the original
|
|
-- Reorganisation rows stay in the record, exactly like every other history
|
|
-- event type. The now-unused delete policy is dropped.
|
|
|
|
drop policy if exists "history_delete_admin_reorg_undo" on employee_history;
|
|
|
|
create or replace function undo_reorg(payload jsonb)
|
|
returns void language plpgsql as $$
|
|
declare
|
|
v_scenario record;
|
|
v_key text;
|
|
v_val jsonb;
|
|
v_name text;
|
|
v_count int := 0;
|
|
begin
|
|
perform require_hr_admin();
|
|
select * into v_scenario from reorg_scenarios where id = (payload->>'scenario_id')::uuid and applied = true;
|
|
if not found or v_scenario.undo_snapshot is null then
|
|
raise exception 'Reorganisation kann nicht rückgängig gemacht werden (kein Snapshot vorhanden).';
|
|
end if;
|
|
|
|
-- Any pending (not-yet-applied) deferred moves belonging to this scenario
|
|
-- are cancelled rather than left to fire later against a since-reverted
|
|
-- state.
|
|
update pending_org_changes set status = 'cancelled'
|
|
where reorg_scenario_id = v_scenario.id and status = 'pending';
|
|
|
|
for v_key, v_val in select * from jsonb_each(v_scenario.undo_snapshot)
|
|
loop
|
|
update employees set
|
|
team_id = nullif(v_val->>'team_id','')::uuid,
|
|
division_id = (v_val->>'division_id')::uuid,
|
|
manager_id = nullif(v_val->>'manager_id','')::uuid
|
|
where id = v_key::uuid;
|
|
|
|
select first_name || ' ' || last_name into v_name from employees where id = v_key::uuid;
|
|
insert into employee_history (employee_id, event_date, event_type, description, reorg_scenario_id)
|
|
values (v_key::uuid, current_date, 'Reorganisation',
|
|
'Reorganisation "' || v_scenario.name || '" rückgängig gemacht — vorheriges Team wiederhergestellt', v_scenario.id);
|
|
|
|
v_count := v_count + 1;
|
|
end loop;
|
|
|
|
update reorg_scenarios set applied = false where id = v_scenario.id;
|
|
|
|
insert into audit_log (actor_user_id, actor_name, action, target_label, details)
|
|
values (auth.uid(), current_actor_name(), 'Reorganisation rückgängig', v_scenario.name, v_count || ' Mitarbeiter:innen zurückgesetzt');
|
|
end;
|
|
$$;
|