Accessibility work on the UI layer, all of it rooted in one structural gap: there were no form primitives, so every field was hand-assembled and every field got the same details wrong. Form primitives - components/ui/Field.tsx (Field/TextField/SelectField/TextareaField) and Button.tsx. Field generates the control id with useId and derives htmlFor from it, which is what makes the association impossible to omit rather than merely conventional. - 92 labels existed, 4 used htmlFor, and no input carried an id at all: a screen reader announced an unnamed edit box and clicking a label focused nothing. Now every label resolves to its control (0 unassociated), and the input class chain that appeared verbatim 85 times appears zero times. - Field also takes a render prop, so Lookup, CountryPicker and Picklist get the same wiring instead of a second, partial solution. - SearchInput replaces three hand-rolled copies of the icon-in-a-box search whose input had only a placeholder — not a label — and killed its own focus ring with outline-none and nothing in its place. - Toggle groups (workdays, reorg change type) became fieldsets with aria-pressed; colour alone was carrying the selected state. Comboboxes - Lookup and CountryPicker were text inputs with a div of clickable buttons underneath: typeable, but no keyboard path to a result and nothing telling a screen reader a list had appeared. Both now carry role=combobox, aria-expanded/controls/activedescendant and listbox semantics, with arrow keys, Enter and Escape. Escape stops propagation, or it would close the surrounding dialog along with the dropdown. Dialogs - useDialogFocus centralises what Modal and SlideOver each owed the keyboard and neither provided beyond Escape: focus into the dialog on open, Tab and Shift+Tab cycling within it, focus restored to the trigger on close. - SlideOver stays mounted for its transition, and aria-hidden does not remove anything from the tab order — so every closed panel was leaving invisible tab stops at the end of the page. `inert` fixes that. Route states - loading.tsx, error.tsx, not-found.tsx and global-error.tsx. Every page in the (app) group is server-rendered per request, so without loading.tsx a navigation showed nothing at all until the server answered, and a render error dropped the user on Next's own screen with no way back. Tests - 22 component tests (vitest jsdom project). Two of them found limits of the environment rather than of the code: jsdom implements neither `inert` nor scrollIntoView, so the inert test asserts the attribute and the missing scrollIntoView — which was taking the whole render down from inside an effect — is stubbed in the setup file.
199 lines
7.4 KiB
TypeScript
199 lines
7.4 KiB
TypeScript
"use client";
|
|
|
|
import { useRouter } from "next/navigation";
|
|
import { useState } from "react";
|
|
import { adjustKarenzReturn, recordKarenzReturn, startKarenz } from "@/actions/employees";
|
|
import { Button } from "@/components/ui/Button";
|
|
import { SelectField, TextField, TextareaField } from "@/components/ui/Field";
|
|
import { SegmentedControl } from "@/components/ui/SegmentedControl";
|
|
import { SlideOver } from "@/components/ui/SlideOver";
|
|
import { useToast } from "@/components/ui/Toast";
|
|
import { fmtDate } from "@/lib/format";
|
|
import type { Database } from "@/lib/supabase/types";
|
|
|
|
type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
|
|
type Mode = "adjust" | "return";
|
|
type EmploymentMode = "unverändert" | "Vollzeit" | "Teilzeit";
|
|
|
|
export function KarenzPanel({ open, onClose, employee }: { open: boolean; onClose: () => void; employee: EmployeeRow }) {
|
|
const { showToast } = useToast();
|
|
const router = useRouter();
|
|
const isOnKarenz = employee.status === "Karenz";
|
|
const [mode, setMode] = useState<Mode>("adjust");
|
|
const [pending, setPending] = useState(false);
|
|
|
|
const [karenzStart, setKarenzStart] = useState("");
|
|
const [plannedReturn, setPlannedReturn] = useState("");
|
|
const [startNote, setStartNote] = useState("");
|
|
|
|
const [newReturnDate, setNewReturnDate] = useState(employee.karenz_return_date ?? "");
|
|
const [adjustNote, setAdjustNote] = useState("");
|
|
|
|
const [returnDate, setReturnDate] = useState("");
|
|
const [employmentMode, setEmploymentMode] = useState<EmploymentMode>("unverändert");
|
|
const [weeklyHours, setWeeklyHours] = useState("20");
|
|
|
|
const diffDays =
|
|
isOnKarenz && employee.karenz_return_date && newReturnDate
|
|
? Math.round((new Date(newReturnDate).getTime() - new Date(employee.karenz_return_date).getTime()) / 86400000)
|
|
: 0;
|
|
|
|
async function handleStart() {
|
|
if (!karenzStart || !plannedReturn) {
|
|
showToast("Bitte beide Daten angeben.", "error");
|
|
return;
|
|
}
|
|
setPending(true);
|
|
const result = await startKarenz({ employee_id: employee.id, karenz_start_date: karenzStart, planned_return_date: plannedReturn, note: startNote });
|
|
setPending(false);
|
|
if (result.success) {
|
|
showToast("Karenz erfasst.");
|
|
router.refresh();
|
|
onClose();
|
|
} else {
|
|
showToast(result.error ?? "Fehler.", "error");
|
|
}
|
|
}
|
|
|
|
async function handleAdjust() {
|
|
if (!newReturnDate || newReturnDate === employee.karenz_return_date) {
|
|
showToast("Bitte ein neues Rückkehrdatum angeben.", "error");
|
|
return;
|
|
}
|
|
if (new Date(newReturnDate) <= new Date()) {
|
|
showToast("Rückkehrdatum muss in der Zukunft liegen.", "error");
|
|
return;
|
|
}
|
|
setPending(true);
|
|
const result = await adjustKarenzReturn({ employee_id: employee.id, new_return_date: newReturnDate, note: adjustNote });
|
|
setPending(false);
|
|
if (result.success) {
|
|
showToast("Rückkehrdatum angepasst.");
|
|
router.refresh();
|
|
onClose();
|
|
} else {
|
|
showToast(result.error ?? "Fehler.", "error");
|
|
}
|
|
}
|
|
|
|
async function handleReturn() {
|
|
if (!returnDate) {
|
|
showToast("Bitte Rückkehrdatum angeben.", "error");
|
|
return;
|
|
}
|
|
if (employmentMode === "Teilzeit" && (Number(weeklyHours) <= 0 || Number(weeklyHours) >= 38.5)) {
|
|
showToast("Wochenstunden müssen zwischen 0 und 38,5 liegen.", "error");
|
|
return;
|
|
}
|
|
setPending(true);
|
|
const result = await recordKarenzReturn({
|
|
employee_id: employee.id,
|
|
return_date: returnDate,
|
|
employment_mode: employmentMode,
|
|
weekly_hours: employmentMode === "Teilzeit" ? Number(weeklyHours) : undefined,
|
|
});
|
|
setPending(false);
|
|
if (result.success) {
|
|
showToast("Wiedereintritt erfasst.");
|
|
router.refresh();
|
|
onClose();
|
|
} else {
|
|
showToast(result.error ?? "Fehler.", "error");
|
|
}
|
|
}
|
|
|
|
return (
|
|
<SlideOver
|
|
open={open}
|
|
onClose={onClose}
|
|
title={isOnKarenz ? "Karenz verwalten" : "Karenz"}
|
|
subtitle={`${employee.first_name} ${employee.last_name} · ${employee.job_title}`}
|
|
footer={
|
|
<>
|
|
<Button variant="ghost" onClick={onClose}>
|
|
Abbrechen
|
|
</Button>
|
|
{/* Karenz keeps the warning tone it uses everywhere else. */}
|
|
{!isOnKarenz && (
|
|
<Button onClick={handleStart} pending={pending} className="!bg-warning-text text-white hover:brightness-110">
|
|
Karenz erfassen
|
|
</Button>
|
|
)}
|
|
{isOnKarenz && mode === "adjust" && (
|
|
<Button onClick={handleAdjust} pending={pending} className="!bg-warning-text text-white hover:brightness-110">
|
|
Speichern
|
|
</Button>
|
|
)}
|
|
{isOnKarenz && mode === "return" && (
|
|
<Button onClick={handleReturn} pending={pending} className="!bg-warning-text text-white hover:brightness-110">
|
|
Wiedereintritt erfassen
|
|
</Button>
|
|
)}
|
|
</>
|
|
}
|
|
>
|
|
{!isOnKarenz && (
|
|
<div className="flex flex-col gap-4">
|
|
<TextField label="Karenzbeginn" required type="date" value={karenzStart} onChange={setKarenzStart} />
|
|
<TextField label="Geplante Rückkehr" required type="date" value={plannedReturn} onChange={setPlannedReturn} />
|
|
<TextareaField label="Anmerkung" rows={3} value={startNote} onChange={setStartNote} />
|
|
</div>
|
|
)}
|
|
|
|
{isOnKarenz && (
|
|
<div className="flex flex-col gap-4">
|
|
<SegmentedControl<Mode>
|
|
value={mode}
|
|
onChange={setMode}
|
|
options={[
|
|
{ value: "adjust", label: "Rückkehr anpassen" },
|
|
{ value: "return", label: "Wiedereintritt erfassen" },
|
|
]}
|
|
/>
|
|
|
|
{mode === "adjust" && (
|
|
<>
|
|
<p className="text-sm text-ink-muted">Aktuelles Rückkehrdatum: {fmtDate(employee.karenz_return_date)}</p>
|
|
<TextField label="Neues Rückkehrdatum" required type="date" value={newReturnDate} onChange={setNewReturnDate} />
|
|
{diffDays !== 0 && (
|
|
<div className={`rounded px-3 py-2 text-sm ${diffDays > 0 ? "bg-warning-bg text-warning-text" : "bg-success-bg text-success-text"}`}>
|
|
{diffDays > 0 ? `Verlängerung um ${diffDays} Tage` : `Verkürzung um ${Math.abs(diffDays)} Tage`}
|
|
</div>
|
|
)}
|
|
<TextareaField label="Grund/Anmerkung" rows={3} value={adjustNote} onChange={setAdjustNote} />
|
|
</>
|
|
)}
|
|
|
|
{mode === "return" && (
|
|
<>
|
|
<TextField label="Rückkehrdatum" required type="date" value={returnDate} onChange={setReturnDate} />
|
|
<SelectField
|
|
label="Beschäftigungsausmaß"
|
|
value={employmentMode}
|
|
onChange={(v) => setEmploymentMode(v as EmploymentMode)}
|
|
options={[
|
|
{ value: "unverändert", label: "unverändert" },
|
|
{ value: "Vollzeit", label: "Vollzeit (38,5h)" },
|
|
{ value: "Teilzeit", label: "Teilzeit-Elternteilzeit" },
|
|
]}
|
|
/>
|
|
{employmentMode === "Teilzeit" && (
|
|
<TextField
|
|
label="Wochenstunden"
|
|
required
|
|
type="number"
|
|
step="0.5"
|
|
max="38"
|
|
value={weeklyHours}
|
|
onChange={setWeeklyHours}
|
|
hint="Muss unter 38,5 liegen."
|
|
/>
|
|
)}
|
|
</>
|
|
)}
|
|
</div>
|
|
)}
|
|
</SlideOver>
|
|
);
|
|
}
|