Maximilian Stubhan
2ba9b37aa7
Auth.js replaces GoTrue. The sign-in still goes to the same Entra tenant,
but nothing sits between the app and the identity provider any more — the
code exchange, state, nonce and the session cookie are ours.
lib/auth/session.ts stays the only place that knows where a user id comes
from, which is why this was one file and not fifty. What it returns is now
app_users.id. app_upsert_user() maps the Entra `oid` onto it, and for an
address that already has a profiles row it adopts that id instead of
minting a new one — otherwise everyone would have been signed in and cut
off from their own notes, drafts and audit trail at the same time.
That upsert is the one write that cannot have a session context yet: the
id is what it produces. It runs as a SECURITY DEFINER function that may
touch app_users and nothing else, which is a far smaller lever than the
service key that used to answer this class of problem.
The proxy no longer checks HR rights. It has no database connection, and
putting role/is_active in the token would have frozen the claim until the
next sign-in. The check moved to where it can read the current truth: the
app layout on every render, requireHrUser() for the export routes, and
underneath both, RLS.
Two things only came out by running it:
- `export const proxy = auth(…)` is not a function declaration, so
Next.js never found it and every request 404'd. `next build` reported
success and listed the proxy. In the function config form auth() also
returns the handler as a promise, so it needs an await. The proxy test
now mocks it as a promise for that reason — a friendlier mock would
let the same bug back in.
- A missing AUTH_MICROSOFT_ENTRA_ID_ISSUER silently falls back to
/common/, and the redirect really did go there. That would let any
Microsoft account sign in, including a private one, and it would never
look broken. It now refuses to start in production.
Neither build nor image needs credentials any more: the pool is created on
first use, the auth config is evaluated per request, and there are no
NEXT_PUBLIC_* values left to bake in. One image now runs in every
environment.
Verified: typecheck, lint, 187 tests, build, and by hand in the browser —
/employees redirects to /login, and the sign-in button reaches the Entra
page with PKCE and the callback URL that goes into the app registration.
Not verified against a real database; there is still no DATABASE_URL.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
56 lines
2.2 KiB
TypeScript
56 lines
2.2 KiB
TypeScript
import "server-only";
|
|
import { Pool } from "pg";
|
|
|
|
// Die einzige Stelle im Projekt, die `pg` importieren darf.
|
|
//
|
|
// Der Grund steht in lib/db/index.ts: eine Abfrage ausserhalb von withUser()
|
|
// läuft ohne Sitzungskontext und damit — je nachdem, was die vorherige
|
|
// Anfrage auf derselben gepoolten Verbindung hinterlassen hat — im Namen
|
|
// einer fremden Person. Deshalb wird der Pool nicht exportiert, sondern nur
|
|
// die Kysely-Instanz, die ihn benutzt, und eine ESLint-Regel verbietet den
|
|
// Import von `pg` und von dieser Datei überall sonst.
|
|
|
|
let instance: Pool | undefined;
|
|
|
|
/**
|
|
* Der Verbindungspool — erst beim ersten Zugriff angelegt, nicht beim Import.
|
|
*
|
|
* Der Unterschied ist nicht kosmetisch: `next build` importiert jedes Route-
|
|
* Modul, um die Seitendaten einzusammeln. Entstünde der Pool dabei, bräuchte
|
|
* schon der Bau Zugangsdaten zur Datenbank — ein Container-Abbild liesse sich
|
|
* in einer Baustrecke ohne Produktionsgeheimnisse nicht mehr erzeugen.
|
|
*/
|
|
export function getPool(): Pool {
|
|
if (instance) return instance;
|
|
|
|
const connectionString = process.env.DATABASE_URL;
|
|
if (!connectionString) {
|
|
throw new Error(
|
|
"DATABASE_URL fehlt. Erwartet wird ein PostgreSQL-Verbindungsstring — " +
|
|
"die Anwendung spricht direkt mit der Datenbank, nicht über eine API-Schicht."
|
|
);
|
|
}
|
|
|
|
instance = new Pool({
|
|
connectionString,
|
|
// Der Standard sind 10; bei serverseitigem Rendering hängt an jeder
|
|
// Anfrage genau eine Transaktion, und mehr Verbindungen als die Datenbank
|
|
// zulässt bringen nur Wartezeit an einer anderen Stelle.
|
|
max: Number(process.env.DATABASE_POOL_MAX ?? 10),
|
|
// Eine Anfrage, die länger braucht, ist kaputt und soll das melden statt
|
|
// eine Verbindung zu belegen.
|
|
statement_timeout: 20_000,
|
|
idle_in_transaction_session_timeout: 20_000,
|
|
connectionTimeoutMillis: 10_000,
|
|
// Verwaltete Anbieter (Azure, RDS, Supabase) verlangen TLS; lokal nicht.
|
|
ssl: process.env.DATABASE_SSL === "false" ? undefined : { rejectUnauthorized: false },
|
|
});
|
|
|
|
// Ein Fehler auf einer Leerlaufverbindung beendet sonst den Prozess.
|
|
instance.on("error", (err) => {
|
|
console.error("Unerwarteter Fehler auf einer Leerlaufverbindung:", err);
|
|
});
|
|
|
|
return instance;
|
|
}
|