Positions
- Removed the "Besetzen" action, the StaffInternallyModal behind it and the
now-unreachable staffPositionInternally server action: a position is filled
through the hire process, not from the positions list. Note that
transfer_employee has no position_id at all and never touched `positions`,
so with staff_position_internally out of the UI, hire_employee is the only
thing that closes a position — a transfer into an open one leaves it open.
The RPC itself is still in the database and still covered by its tests.
SVNR
- Austrian social security numbers are now validated: ten digits, weighted
check digit mod 11, and the TTMMJJ tail cross-checked against birth_date,
which is what catches a transposed date that a valid check digit would let
through. A serial whose weighted sum lands on 11 is rejected rather than
wrapped — those are never issued.
- Applies to Austrian locations only; the German/Czech/Slovenian equivalents
have their own formats and stay free-form.
- Enforced by a trigger, not inside hire_employee/change_employee_data, for
the same reason as the assignment history: both have been redefined by
half a dozen migrations. Only a *newly written* value is checked, so a
legacy number never blocks an unrelated transfer or address change.
- The seed drew a random four-digit prefix, so its check digit was right
only by chance and every seeded Austrian row would now be rejected;
it computes the check digit properly now.
Tech stack
- next 16.2.11 closes nine advisories against 16.2.10, including a
middleware/proxy bypass in App Router apps on Turbopack — proxy.ts is this
app's entry gate. RLS remains the real boundary, so the blast radius was a
blank page rather than data, but it is a patch-level fix. Also react
19.2.8, tailwind 4.3.3, lucide-react 1.26, supabase-js/ssr, postcss.
- CI runs lint, typecheck, schema/type drift, tests and build; a second job
replays every migration onto an empty database and runs the integration
suite against it, so a migration that cannot be replayed from scratch
fails here instead of during a restore.
- scripts/check-schema-types.mjs diffs the hand-written lib/supabase/types.ts
against the migrations. Reading the SQL rather than a live database keeps
Postgres out of the fast CI job. Verified in both directions.
- vitest now runs two projects: node for logic, jsdom for components. The
first component test covers the org chart expand control, which broke
earlier this session when elementsSelectable={false} made React Flow
compute pointer-events:none for the whole node; re-introducing that prop
fails three of these tests.
- Content-Security-Policy is emitted report-only. Enforcing a policy derived
from inspection rather than from violation reports risks blanking the app;
'unsafe-inline' on script-src is required until a nonce is threaded through
proxy.ts, which is a separate change.
- Fixed supabase/seed.ts, which this session's SVNR change had broken: the
extensionless "../lib/svnr" import does not resolve under Node's ESM
loader, so the seed failed at startup.
- engines pinned to node >=22 <25, tsconfig target ES2022, and the dead
test:e2e script removed (no Playwright is installed).
112 lines
4.0 KiB
TypeScript
112 lines
4.0 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { formatSvnr, isValidSvnr, normalizeSvnr, requiresAustrianSvnr, svnrCheckDigit, validateSvnr } from "@/lib/svnr";
|
|
|
|
// Weights 3,7,9 on the serial and 5,8,4,2,1,6 on TTMMJJ; sum mod 11 is the
|
|
// check digit. Worked through by hand for "123? 010180":
|
|
// 3·1 + 7·2 + 9·3 = 44 (serial)
|
|
// 5·0 + 8·1 + 4·0 + 2·1 + 1·8 + 6·0 = 18 (010180)
|
|
// 62 mod 11 = 7 → 1237 010180
|
|
const VALID = "1237 010180";
|
|
|
|
describe("svnrCheckDigit", () => {
|
|
it("computes the documented check digit", () => {
|
|
expect(svnrCheckDigit("1230010180")).toBe(7);
|
|
});
|
|
|
|
it("computes it independently of the digit already in that slot", () => {
|
|
// The check position is skipped, so a wrong digit there cannot influence
|
|
// the result — otherwise the check would validate itself.
|
|
expect(svnrCheckDigit("1234010180")).toBe(7);
|
|
expect(svnrCheckDigit("1239010180")).toBe(7);
|
|
});
|
|
|
|
it("computes 3 for serial 432 on the same date", () => {
|
|
// 3·4 + 7·3 + 9·2 = 51; 51 + 18 = 69; 69 mod 11 = 3
|
|
expect(svnrCheckDigit("4320010180")).toBe(3);
|
|
});
|
|
|
|
it("returns null for a serial that would need a check digit of 10", () => {
|
|
// 9·4 = 36; 36 + 18 = 54; 54 mod 11 = 10 — never issued, since there is
|
|
// no single digit for it.
|
|
expect(svnrCheckDigit("0040010180")).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("validateSvnr", () => {
|
|
it("accepts a well-formed number", () => {
|
|
expect(validateSvnr(VALID)).toBeNull();
|
|
expect(isValidSvnr(VALID)).toBe(true);
|
|
});
|
|
|
|
it("accepts it regardless of spacing or separators", () => {
|
|
for (const variant of ["1237010180", "1237 010180", "1237-010180", "1237.010180", " 1237 010180 "]) {
|
|
expect(validateSvnr(variant), variant).toBeNull();
|
|
}
|
|
});
|
|
|
|
it("rejects a wrong check digit", () => {
|
|
expect(validateSvnr("1234 010180")).toBe("checksum");
|
|
});
|
|
|
|
it("rejects a serial whose check digit would be 10", () => {
|
|
expect(validateSvnr("0040 010180")).toBe("checksum");
|
|
});
|
|
|
|
it("rejects anything that is not ten digits", () => {
|
|
for (const bad of ["", "123701018", "12370101801", "1237 01018X", "abcdefghij"]) {
|
|
expect(validateSvnr(bad), bad).toBe("length");
|
|
}
|
|
});
|
|
|
|
it("rejects the unissued 000 serial", () => {
|
|
expect(validateSvnr("0007 010180")).toBe("serial");
|
|
});
|
|
|
|
it("rejects an impossible date tail", () => {
|
|
// Month 13 and day 32 never occur; the checksum is irrelevant once the
|
|
// tail cannot be a date at all.
|
|
expect(validateSvnr("1237 011380")).toBe("date");
|
|
expect(validateSvnr("1237 320180")).toBe("date");
|
|
expect(validateSvnr("1237 310280")).toBe("date");
|
|
});
|
|
|
|
it("allows 29 February, which a two-digit year cannot disambiguate", () => {
|
|
// 3·1+7·2+9·3 = 44; 5·2+8·9+4·0+2·2+1·8+6·0 = 10+72+0+4+8 = 94; 138 mod 11 = 6
|
|
expect(validateSvnr("1236 290280")).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("cross-check against the stored birth date", () => {
|
|
it("passes when the tail matches", () => {
|
|
expect(validateSvnr(VALID, "1980-01-01")).toBeNull();
|
|
});
|
|
|
|
it("catches a transposed birth date the checksum cannot", () => {
|
|
expect(validateSvnr(VALID, "1980-01-02")).toBe("birthDateMismatch");
|
|
expect(validateSvnr(VALID, "1981-01-01")).toBe("birthDateMismatch");
|
|
});
|
|
|
|
it("skips the cross-check when no birth date is known", () => {
|
|
expect(validateSvnr(VALID, null)).toBeNull();
|
|
expect(validateSvnr(VALID, undefined)).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("helpers", () => {
|
|
it("normalises and formats", () => {
|
|
expect(normalizeSvnr("1237 010180")).toBe("1237010180");
|
|
expect(formatSvnr("1237010180")).toBe("1237 010180");
|
|
});
|
|
|
|
it("leaves non-canonical input alone when formatting", () => {
|
|
expect(formatSvnr("12")).toBe("12");
|
|
});
|
|
|
|
it("applies only to Austrian locations", () => {
|
|
expect(requiresAustrianSvnr("Österreich")).toBe(true);
|
|
for (const c of ["Deutschland", "Tschechien", "Slowenien", null, undefined]) {
|
|
expect(requiresAustrianSvnr(c)).toBe(false);
|
|
}
|
|
});
|
|
});
|