Maximilian Stubhan
79f0e19bf8
Data model - employee_assignments records org placement over time (valid_from/valid_to), written by a trigger on `employees` rather than inside each RPC: ~70 `update employees` statements spread over fifteen migrations mean per-call bookkeeping would miss paths today and again with every future RPC. A partial unique index enforces the one-open-interval invariant the trigger relies on when closing the current row. - The Organigramm gains a Stichtag (default today). Membership comes from entry/exit/karenz, past placement from the new history, future placement projected from pending_org_changes. Placements predating the migration are backfilled with today's values and flagged as such in the UI, since employee_history only ever stored free text and cannot be reconstructed. Correctness - Reports and exports silently truncated at PostgREST's 1000-row cap (db.max_rows); employee_history is already past it at ~800 staff. Every whole-table read now pages explicitly. - XLSX date cells were a day early: ExcelJS converts a Date to an Excel serial straight off getTime(), so a Date built at local midnight lands on the previous day's serial in any positive-offset zone. - Date handling is pinned to Europe/Vienna throughout, and date-only strings are formatted without a Date round-trip. The dashboard's YTD window was built by round-tripping a local Date through toISOString(), which shifted it a day early and dropped 31 December entirely. - Export routes parsed measure/group/split/eventType with unchecked `as` casts, so an unknown value reached column headers as `undefined` and the Content-Disposition filename. Parsed against the label maps now, with the filename slugged as a backstop. - toXlsx keyed columns by header text, silently dropping the second of any two columns sharing a name — split columns take their header from data. - The org chart tree walks had no cycle guard; nothing in the schema forbids a manager_id cycle, and one would hang the tab rather than misreport. - The login page reflected ?error= verbatim, letting anyone put arbitrary text on the real sign-in screen; messages are looked up by code now. - React Flow needs elementsSelectable on, or it sets pointer-events:none on the whole node and the expand control stops responding. UI - Mobile: the shell was unusable below lg — a fixed 236px margin pushed content off-screen with no mobile navigation at all. The sidebar is now a drawer, dvh replaces vh, safe-area insets are honoured, inputs are 16px so iOS stops zooming on focus, and form grids stack. - Org chart nodes redesigned: per-kind accent stripes and icons, vacant roles called out, expand control moved to the bottom edge carrying the child count. - Pagination is windowed; it previously rendered one link per page (54 for the employee list, unbounded for the audit log). - Positions page reduced to open positions with a single "Besetzen" action. - The employee Organisation tab links into the org chart focused on that person, reusing the chart's existing search-match highlighting. Also included, uncommitted until now - Dependants, HR notes, academic titles, split address fields, position validity and role/employment fields, with their migrations and UI. - Docker/compose deployment setup, data-model and security-review docs.
79 lines
3.4 KiB
PL/PgSQL
79 lines
3.4 KiB
PL/PgSQL
-- "Angehörige" — dependents/family members tracked per employee (spouse,
|
|
-- children, ...), relevant for payroll/insurance. One employee can have
|
|
-- several. Editing is add/remove only — fix a mistaken entry by deleting
|
|
-- and re-adding it, same as "Position löschen" — no in-place edit RPC.
|
|
|
|
create table employee_dependents (
|
|
id uuid primary key default gen_random_uuid(),
|
|
employee_id uuid not null references employees(id) on delete cascade,
|
|
first_name text not null,
|
|
last_name text not null,
|
|
relationship text not null check (relationship in ('Ehepartner:in', 'Lebenspartner:in', 'Kind', 'Sonstige')),
|
|
sv_nummer text,
|
|
birth_date date not null,
|
|
created_at timestamptz not null default now()
|
|
);
|
|
create index on employee_dependents (employee_id);
|
|
|
|
-- RLS only narrows what an already-GRANTed role may do; the "grant all ...
|
|
-- to anon, authenticated, service_role" default privilege (see
|
|
-- 20260714120500_default_grants.sql) already covers this new table.
|
|
alter table employee_dependents enable row level security;
|
|
create policy "employee_dependents_hr_all" on employee_dependents for all
|
|
using (is_hr_user()) with check (is_hr_user());
|
|
|
|
-- ── Angehörige:n hinzufügen ───────────────────────────────────────────
|
|
create or replace function add_employee_dependent(payload jsonb)
|
|
returns uuid language plpgsql as $$
|
|
declare
|
|
v_id uuid;
|
|
v_employee_id uuid := (payload->>'employee_id')::uuid;
|
|
v_employee_name text;
|
|
begin
|
|
perform require_hr_admin();
|
|
select first_name || ' ' || last_name into v_employee_name from employees where id = v_employee_id;
|
|
if not found then
|
|
raise exception 'Mitarbeiter:in nicht gefunden.';
|
|
end if;
|
|
|
|
insert into employee_dependents (employee_id, first_name, last_name, relationship, sv_nummer, birth_date)
|
|
values (
|
|
v_employee_id, payload->>'first_name', payload->>'last_name', payload->>'relationship',
|
|
nullif(payload->>'sv_nummer', ''), (payload->>'birth_date')::date
|
|
)
|
|
returning id into v_id;
|
|
|
|
insert into audit_log (actor_user_id, actor_name, action, target_label, target_employee_id, details)
|
|
values (
|
|
auth.uid(), current_actor_name(), 'Angehörige:r hinzugefügt', v_employee_name, v_employee_id,
|
|
(payload->>'first_name') || ' ' || (payload->>'last_name') || ' (' || (payload->>'relationship') || ')'
|
|
);
|
|
|
|
return v_id;
|
|
end;
|
|
$$;
|
|
|
|
-- ── Angehörige:n entfernen ────────────────────────────────────────────
|
|
create or replace function delete_employee_dependent(payload jsonb)
|
|
returns void language plpgsql as $$
|
|
declare
|
|
v_dep employee_dependents%rowtype;
|
|
v_employee_name text;
|
|
begin
|
|
perform require_hr_admin();
|
|
select * into v_dep from employee_dependents where id = (payload->>'dependent_id')::uuid;
|
|
if not found then
|
|
raise exception 'Angehörige:r nicht gefunden.';
|
|
end if;
|
|
select first_name || ' ' || last_name into v_employee_name from employees where id = v_dep.employee_id;
|
|
|
|
delete from employee_dependents where id = v_dep.id;
|
|
|
|
insert into audit_log (actor_user_id, actor_name, action, target_label, target_employee_id, details)
|
|
values (
|
|
auth.uid(), current_actor_name(), 'Angehörige:r entfernt', v_employee_name, v_dep.employee_id,
|
|
v_dep.first_name || ' ' || v_dep.last_name || ' (' || v_dep.relationship || ')'
|
|
);
|
|
end;
|
|
$$;
|