Maximilian Stubhan
b87c8ad64c
The database moved to a container of our own; the platform is gone. This takes out what was left of it — and, where the leftovers were load bearing, moves rather than deletes. Moved, not deleted: supabase/migrations/ -> db/migrations/ the schema's source of truth supabase/build-org.ts -> scripts/build-org.ts lib/supabase/types.ts -> lib/types.ts 52 import sites repointed The bookkeeping needed care. It lived in `supabase_migrations.schema_migrations`, and simply renaming the schema would have left the runner facing an empty table: it would have called all 67 migrations pending and replayed them against a database that is long since current. So the runner now creates `migrationen.schema_migrations` and, once, copies the old rows across — guarded so a second run does nothing and a fresh database skips it entirely. Only then does migration 20260907100000 drop the old schema. Deleted: the CLI config, the seed, the historical schema/function dumps (nothing read them), scripts/umzug-von-supabase.sh (the move is done), and both Supabase packages plus the CLI. Nothing in the application imported them — the build now succeeds with no environment variables at all, which is the proof. Integration tests: six of them signed in through Supabase Auth and asserted against the anon key and the service role. That model is gone, so the tests were not portable — they are deleted. session-context and employee-status-filter already ran on pg and are untouched; om-reporting is ported to a direct connection because it guards a real risk (the reporting line rule exists twice, once in SQL and once in TypeScript). CI: the integration job started a Supabase stack. It now runs a postgres service, applies deploy/db-init and every migration to an empty database — that was the valuable part, and it still holds — then checks that a second run is a no-op, which is what proves the bookkeeping works. Docs: security-review.md audited a service-role key, a cookie adapter and auth.users, none of which exist. Restating findings about removed components would suggest today's system had been reviewed; it has not. It now records what was removed and says a fresh review is due. data-model.md was already marked obsolete and described the pre-OM schema; azure-migration.md was a plan for a route not taken. Both deleted. Verified: npm ci, typecheck, lint, 445 tests, build — all clean without the packages. Integration tests skip cleanly with no database. Migration SQL and the runner are reviewed but NOT executed: no Docker here, and the old instance no longer resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
83 lines
3.0 KiB
SQL
83 lines
3.0 KiB
SQL
-- Die Wiedereinstellung prüft die Zielplanstelle wie Eintritt und Versetzung.
|
|
--
|
|
-- rehire_employee verlangte zwar eine Planstelle, setzte die Besetzung dann
|
|
-- aber ungeprüft: weder ob die Stelle zum Wiedereintritt gilt noch ob sie
|
|
-- frei ist. Eine wiedereingestellte Person konnte damit auf einer bereits
|
|
-- besetzten Stelle landen — abgefangen erst vom Teilindex, mit einer Meldung,
|
|
-- die in der Oberfläche nichts erklärt — oder auf einer, die es zu dem Datum
|
|
-- gar nicht gibt.
|
|
--
|
|
-- Dieselbe Regel wie in 20260810100000: das Datum muss in
|
|
-- [valid_from, valid_to) liegen, und es darf keine Zuordnung geben, die zu
|
|
-- diesem Zeitpunkt noch gilt.
|
|
|
|
do $$
|
|
declare
|
|
v_def text;
|
|
v_neu text;
|
|
begin
|
|
select pg_get_functiondef(p.oid) into v_def
|
|
from pg_proc p
|
|
join pg_namespace n on n.oid = p.pronamespace
|
|
where n.nspname = 'public' and p.proname = 'rehire_employee'
|
|
limit 1;
|
|
|
|
if v_def is null then
|
|
raise exception 'rehire_employee() nicht gefunden.';
|
|
end if;
|
|
|
|
-- Über ein Muster, weil der Rumpf CRLF enthalten kann; ein wörtlicher
|
|
-- Vergleich fände nichts und die Migration meldete trotzdem Erfolg.
|
|
v_neu := regexp_replace(
|
|
v_def,
|
|
'if\s+v_position_id\s+is\s+null\s+then\s+raise\s+exception\s+''Für die Wiedereinstellung muss eine Planstelle angegeben werden\.'';\s+end\s+if;',
|
|
$neu$if v_position_id is null then
|
|
raise exception 'Für die Wiedereinstellung muss eine Planstelle angegeben werden.';
|
|
end if;
|
|
|
|
declare
|
|
v_ab date;
|
|
v_bis date;
|
|
v_besetzt uuid;
|
|
begin
|
|
select valid_from, valid_to into v_ab, v_bis from om_positions where id = v_position_id;
|
|
if v_ab is null then
|
|
raise exception 'Die Planstelle existiert nicht.';
|
|
end if;
|
|
if v_date < v_ab then
|
|
raise exception 'Die Planstelle gilt erst ab %. Ein Wiedereintritt am % ist darauf nicht möglich.', v_ab, v_date;
|
|
end if;
|
|
if v_bis is not null and v_date >= v_bis then
|
|
raise exception 'Die Planstelle gilt nur bis %. Ein Wiedereintritt am % ist darauf nicht möglich.', v_bis, v_date;
|
|
end if;
|
|
|
|
select pa.employee_id into v_besetzt
|
|
from position_assignments pa
|
|
where pa.position_id = v_position_id
|
|
and (pa.valid_to is null or pa.valid_to > v_date);
|
|
if v_besetzt is not null then
|
|
raise exception 'Diese Planstelle ist bereits besetzt.';
|
|
end if;
|
|
end;$neu$,
|
|
'g'
|
|
);
|
|
|
|
if v_neu = v_def then
|
|
raise exception 'Das Muster passte nicht — rehire_employee blieb unverändert.';
|
|
end if;
|
|
|
|
execute v_neu;
|
|
end;
|
|
$$;
|
|
|
|
-- ═══ Gegenprobe ══════════════════════════════════════════════════
|
|
do $$
|
|
begin
|
|
if (select pg_get_functiondef(p.oid) from pg_proc p
|
|
join pg_namespace n on n.oid = p.pronamespace
|
|
where n.nspname = 'public' and p.proname = 'rehire_employee' limit 1) not like '%gilt erst ab%' then
|
|
raise exception 'rehire_employee() enthält die Gültigkeitsprüfung nicht.';
|
|
end if;
|
|
end;
|
|
$$;
|