Give exits their own checklist, next to the entry one
The offboarding list was a checkbox fieldset inside the exit panel — four items, never sent anywhere. Nothing in terminateEmployee's payload carried them; ticking a box there recorded exactly nothing. It's replaced with the same kind of list the entries got: its own tab, appearing the moment an exit is recorded, with one item per row, a comment on each, and — unlike the fieldset — a record of who touched it and when. The eleven items come from the same printed sheet as the entry list. Nine are plain checkboxes. Two are text fields under "Vermerke": remaining vacation and the balance transferred for payout — the sheet names "Überleitung Salden für Auszahlung" twice, once as a task to do and once as the actual figure, and those are genuinely two different questions, kept as two items. Where the sheet still says "GKK" rather than today's "ÖGK", it's left as written — that's the name the process runs under internally, not a typo. No Show gets no list. Never having worked a single day, there's no IT access to revoke, no GKK registration to undo, no Dienstzettel to collect — an empty checklist there would be a label with nothing behind it. Both the tab and the auto-creation on exit check for this specifically, not just the "Ausgetreten" status that No Show shares with a real exit. Rehiring the same person hides the tab again — the data stays, since it happened, but a checklist for someone currently working has nothing to point at. The engine (what counts as done, how progress is computed) moved into lib/checklist.ts so onboarding and offboarding can't drift into two different ideas of "done" the way two independent copies eventually do; lib/onboarding.ts and lib/offboarding.ts bind it to their own item list, and the tab UI is a single ChecklistPanel bound the same way. Checked against the real database: a real exit creates all eleven items in the same transaction as the exit itself; a No Show creates none; rehiring flips the tab off while the old answers stay queryable. One false alarm during that check turned out to be the user's own clicks on a real employee's onboarding list, made in the browser while trying the earlier feature — left untouched, not test debris. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -4,6 +4,7 @@ import { revalidatePath } from "next/cache";
|
||||
import { currentUserId } from "@/lib/auth/session";
|
||||
import { withUser } from "@/lib/db";
|
||||
import { callFunction, runMutation, type ActionResult, type MutationFn } from "@/lib/db/rpc";
|
||||
import { OFFBOARDING_PUNKTE } from "@/lib/offboarding";
|
||||
import { ONBOARDING_PUNKTE } from "@/lib/onboarding";
|
||||
import type { CollectiveAgreement, DienstwagenArt, NoteCategory, RelationshipType, Weekday, WorkerType } from "@/lib/supabase/types";
|
||||
|
||||
@@ -91,7 +92,50 @@ export async function terminateEmployee(payload: {
|
||||
exit_reason: string;
|
||||
note?: string;
|
||||
}): Promise<ActionResult> {
|
||||
return callRpc("terminate_employee", payload, [`/employees/${payload.employee_id}`, "/employees", "/"]);
|
||||
// No Show ist kein Austritt im gewohnten Sinn — die Person hat nie
|
||||
// angefangen. Dafür gibt es nichts offzuboarden: keinen IT-Zugang, der
|
||||
// eingerichtet wurde, keine GKK-Anmeldung, kein Dienstzettel. Die Liste
|
||||
// entstünde leer und wäre ein Etikett ohne Inhalt.
|
||||
if (payload.exit_reason === "No Show") {
|
||||
return callRpc("terminate_employee", payload, [`/employees/${payload.employee_id}`, "/employees", "/"]);
|
||||
}
|
||||
|
||||
try {
|
||||
await withUser(await currentUserId(), async (tx) => {
|
||||
await callFunction(tx, "terminate_employee", payload as unknown as Record<string, unknown>);
|
||||
// In derselben Transaktion: ein Austritt ohne Checkliste wäre ein
|
||||
// halb erfasster Austritt, und sie später anzulegen hiesse, dass
|
||||
// jemand daran denken muss.
|
||||
await callFunction(tx, "start_offboarding", {
|
||||
employee_id: payload.employee_id,
|
||||
item_keys: OFFBOARDING_PUNKTE.map((x) => x.key),
|
||||
});
|
||||
});
|
||||
} catch (err) {
|
||||
return { success: false, error: err instanceof Error ? err.message : "Unbekannter Fehler." };
|
||||
}
|
||||
for (const path of [`/employees/${payload.employee_id}`, "/employees", "/"]) revalidatePath(path);
|
||||
return { success: true };
|
||||
}
|
||||
|
||||
/** Einen Punkt der Offboarding-Checkliste festhalten — Haken, Wert oder Kommentar. */
|
||||
export async function setOffboardingTask(payload: {
|
||||
employee_id: string;
|
||||
item_key: string;
|
||||
erledigt?: boolean;
|
||||
wert?: string | null;
|
||||
kommentar?: string | null;
|
||||
}): Promise<ActionResult> {
|
||||
return callRpc("set_offboarding_task", payload, [`/employees/${payload.employee_id}`]);
|
||||
}
|
||||
|
||||
/** Legt die Offboarding-Checkliste nachträglich an — für Austritte von vor dieser Liste. */
|
||||
export async function startOffboarding(employeeId: string): Promise<ActionResult> {
|
||||
return callRpc(
|
||||
"start_offboarding",
|
||||
{ employee_id: employeeId, item_keys: OFFBOARDING_PUNKTE.map((x) => x.key) },
|
||||
[`/employees/${employeeId}`]
|
||||
);
|
||||
}
|
||||
|
||||
export async function transferEmployee(payload: {
|
||||
|
||||
Reference in New Issue
Block a user