Turn the note filter around: yours by default, colleagues added
Yesterday's version had it the other way — everyone visible, untick to
hide. The decision from the business side is the opposite: you see your
own notes, and you tick the colleagues you also want. So note_mutes
becomes note_subscriptions and the predicate flips from `not exists` to
`exists`.
The existing rows are not carried over. The meaning inverts rather than
the sign: converting faithfully ("everyone except the muted") would write
almost the whole roster into the new table and reproduce exactly the state
the change is meant to end. Anyone opening the setting tomorrow would
think it had not taken effect. The table is a day old; what is lost is a
few ticks from trying it out.
What this costs is worth saying plainly: the silent case that could not
happen under exceptions can happen now. Do not tick a colleague and you
will not see her follow-ups — not while she is on holiday either. That is
the flip side of the decision, and it is written down in the migration
rather than discovered later.
Each note now says who wrote it. Own notes read "von mir" rather than
repeating your own name, which would sit on every second line and tell
nobody anything. The flag is computed on the server: the user id is
already there, and threading it through four components for one word is a
poor trade. The counter on the button follows the same turn — "+2" for
what you added, nothing when you added nothing.
Verified: 21 tests, five mutation-checked (restoring `not exists`,
dropping the own-notes clause, inverting the default, hiding the author,
and printing your own name instead of "von mir" each turn them red). 489
tests, typecheck, lint, schema drift and build clean. The migration is
reviewed but not run — no reachable database here.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -42,12 +42,15 @@ describe("sichtbareNotizen", () => {
|
||||
expect(sql()).toContain('"n"."author_user_id" = $');
|
||||
});
|
||||
|
||||
it("blendet nur aus, wer ausdrücklich abgewählt wurde", () => {
|
||||
it("holt dazu, wer ausdrücklich hinzugewählt wurde", () => {
|
||||
// Vorzeichen und Tabelle zusammen: ein `not exists` auf derselben
|
||||
// Tabelle kehrte die Bedeutung um, ohne dass ein Wort sich änderte.
|
||||
const s = sql();
|
||||
expect(s).toContain("not exists");
|
||||
expect(s).toContain("from note_mutes m");
|
||||
expect(s).toContain("m.user_id = $");
|
||||
expect(s).toContain("m.muted_user_id = \"n\".\"author_user_id\"");
|
||||
expect(s).toContain("exists");
|
||||
expect(s).not.toContain("not exists");
|
||||
expect(s).toContain("from note_subscriptions s");
|
||||
expect(s).toContain("s.user_id = $");
|
||||
expect(s).toContain("s.author_user_id = \"n\".\"author_user_id\"");
|
||||
});
|
||||
|
||||
it("verknüpft die drei Fälle mit ODER, nicht mit UND", () => {
|
||||
@@ -89,16 +92,16 @@ describe("baueKollegen", () => {
|
||||
{ id: "c", full_name: " ", email: "c@example.test" },
|
||||
];
|
||||
|
||||
it("hakt an, wer nicht abgewählt ist", () => {
|
||||
// Der Standard ist „alle sichtbar": gespeichert wird das Abgewählte.
|
||||
expect(baueKollegen(leute, []).map((k) => k.sichtbar)).toEqual([true, true, true]);
|
||||
it("lässt ohne Auswahl alle Haken leer", () => {
|
||||
// Die Vorgabe ist die eigene Person; wer mehr will, wählt hinzu.
|
||||
expect(baueKollegen(leute, []).map((k) => k.sichtbar)).toEqual([false, false, false]);
|
||||
});
|
||||
|
||||
it("nimmt den Haken weg, wo eine Ausnahme steht", () => {
|
||||
it("setzt den Haken, wo ein Abo steht", () => {
|
||||
expect(baueKollegen(leute, ["b"]).map((k) => [k.id, k.sichtbar])).toEqual([
|
||||
["a", true],
|
||||
["b", false],
|
||||
["c", true],
|
||||
["a", false],
|
||||
["b", true],
|
||||
["c", false],
|
||||
]);
|
||||
});
|
||||
|
||||
@@ -112,9 +115,9 @@ describe("baueKollegen", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
it("kommt mit einer Ausnahme zurecht, zu der es niemanden mehr gibt", () => {
|
||||
it("kommt mit einem Abo zurecht, zu dem es niemanden mehr gibt", () => {
|
||||
// Wer die Personalabteilung verlässt, verschwindet aus der Liste; die
|
||||
// Zeile in note_mutes bleibt, bis der Fremdschlüssel sie räumt.
|
||||
// Zeile bleibt, bis der Fremdschlüssel sie räumt.
|
||||
expect(baueKollegen(leute, ["längst-weg"])).toHaveLength(3);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user