Turn the note filter around: yours by default, colleagues added
All checks were successful
CI / Lint, Typen, Tests, Build (push) Successful in 11m36s
CI / Migrationen auf leerer Datenbank (push) Successful in 10m10s

Yesterday's version had it the other way — everyone visible, untick to
hide. The decision from the business side is the opposite: you see your
own notes, and you tick the colleagues you also want. So note_mutes
becomes note_subscriptions and the predicate flips from `not exists` to
`exists`.

The existing rows are not carried over. The meaning inverts rather than
the sign: converting faithfully ("everyone except the muted") would write
almost the whole roster into the new table and reproduce exactly the state
the change is meant to end. Anyone opening the setting tomorrow would
think it had not taken effect. The table is a day old; what is lost is a
few ticks from trying it out.

What this costs is worth saying plainly: the silent case that could not
happen under exceptions can happen now. Do not tick a colleague and you
will not see her follow-ups — not while she is on holiday either. That is
the flip side of the decision, and it is written down in the migration
rather than discovered later.

Each note now says who wrote it. Own notes read "von mir" rather than
repeating your own name, which would sit on every second line and tell
nobody anything. The flag is computed on the server: the user id is
already there, and threading it through four components for one word is a
poor trade. The counter on the button follows the same turn — "+2" for
what you added, nothing when you added nothing.

Verified: 21 tests, five mutation-checked (restoring `not exists`,
dropping the own-notes clause, inverting the default, hiding the author,
and printing your own name instead of "von mir" each turn them red). 489
tests, typecheck, lint, schema drift and build clean. The migration is
reviewed but not run — no reachable database here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-09-10 11:36:38 +02:00
parent 6903013548
commit e8e675fd07
8 changed files with 217 additions and 80 deletions

View File

@@ -21,6 +21,8 @@ const KOLLEGEN: Kollege[] = [
{ id: "b", name: "Bernd Huber", sichtbar: false },
];
// Die Vorgabe ist die eigene Person: ohne Haken sieht man nur sich selbst.
function notiz(teil: Partial<OpenNote> = {}): OpenNote {
return {
id: "n1",
@@ -35,6 +37,7 @@ function notiz(teil: Partial<OpenNote> = {}): OpenNote {
done_at: null,
created_at: "2026-09-01T08:00:00.000Z",
employeeName: "Manuel Aigner",
vonMir: false,
...teil,
} as OpenNote;
}
@@ -78,6 +81,7 @@ describe("Sichtbarkeit der Kolleg:innen", () => {
});
it("meldet beim Abwählen die Kennung und den neuen Stand", async () => {
// sichtbar: false heisst jetzt „Abo entfernen", nicht „ausblenden".
const user = userEvent.setup();
zeige();
await oeffneEinstellung(user);
@@ -111,16 +115,37 @@ describe("Sichtbarkeit der Kolleg:innen", () => {
expect(await screen.findByText("Nicht gespeichert.")).toBeInTheDocument();
});
it("nennt die Zahl der Ausgeblendeten nur, wenn eingeschränkt ist", async () => {
it("nennt die Zahl der Hinzugewählten nur, wenn welche da sind", async () => {
const user = userEvent.setup();
const { unmount } = zeige();
await user.click(screen.getByRole("button", { name: /Meine Notizen/i }));
expect(screen.getByRole("button", { name: /Kolleg:innen/i })).toHaveTextContent("(1 aus)");
expect(screen.getByRole("button", { name: /Kolleg:innen/i })).toHaveTextContent("+1");
unmount();
zeige(KOLLEGEN.map((k) => ({ ...k, sichtbar: true })));
// Niemand hinzugewählt: die Vorgabe. Eine „+0" wäre bei jedem
// Aufschlagen zu lesen und sagte nichts.
zeige(KOLLEGEN.map((k) => ({ ...k, sichtbar: false })));
await user.click(screen.getByRole("button", { name: /Meine Notizen/i }));
expect(screen.getByRole("button", { name: /Kolleg:innen/i })).not.toHaveTextContent("aus)");
expect(screen.getByRole("button", { name: /Kolleg:innen/i })).not.toHaveTextContent("+");
});
it("nennt an jeder Notiz den Verfasser", async () => {
// Sichtbar sind die eigenen und die hinzugewählten — ohne diese Zeile
// wäre nicht zu unterscheiden, welche davon man gerade liest.
const user = userEvent.setup();
zeige(KOLLEGEN, [notiz({ author_name: "Anna Berger" })]);
await user.click(screen.getByRole("button", { name: /Meine Notizen/i }));
expect(screen.getByText("von Anna Berger")).toBeInTheDocument();
});
it("sagt bei eigenen Notizen: von mir", async () => {
// Der eigene Name stünde an jeder zweiten Zeile und sagte nichts — man
// kennt ihn.
const user = userEvent.setup();
zeige(KOLLEGEN, [notiz({ vonMir: true, author_name: "Max Stubhan" })]);
await user.click(screen.getByRole("button", { name: /Meine Notizen/i }));
expect(screen.getByText("von mir")).toBeInTheDocument();
expect(screen.queryByText(/Max Stubhan/)).not.toBeInTheDocument();
});
it("kommt ohne Kolleg:innen zurecht", async () => {