Stop waiting on the network eleven times per page

The app got slower as pages grew, and the reason was not the queries. It
was their number.

A transaction is pinned to one connection, and a connection runs queries
one after another. Every Promise.all in a withUser block looked like
concurrency and was a queue. Measured against the real database: the
round trip is ~36 ms, ten trivial `select 1` over one connection take
343 ms, over ten connections 39 ms. Nothing here is slow — the whole
dashboard payload is under 200 kB, and every table is around a thousand
rows.

More connections is the wrong answer: the RLS session context is per
transaction, so parallel reads mean parallel transactions, and those
multiply the connections the database will grant. Fewer round trips
instead. Postgres will return each sub-select as its own JSON column of
one result.

Per page view, counting the transaction frame:

  shell (paid by every page)  10 → 4
  overview                    14 → 5
  employee file               14 → 7
  employee list                8 → 6

The overview plus its shell went from 24 round trips to 9 — about 860 ms
of pure waiting down to about 320 ms.

The one trap is documented where it bites: inside json_agg, Postgres
formats values itself and the driver's parsers (lib/db/pool.ts) never
see them. Dates, numerics and uuids come out identical; timestamptz does
not — "+00:00" where the driver gives "…Z". Timestamps are compared as
strings in lib/history.ts to decide what happened later, and those two
forms sort against each other wrongly. Every timestamptz in a bundled
query therefore goes through zeitstempel(), which was checked
character-for-character against the driver.

Four loaders moved out of their pages into lib/ so the number of round
trips can be measured without building a React tree, and so the new path
could be held against the old one field by field: same rows, same order,
same strings, for the overview and for four employee files chosen to
differ (with history, a chief, a planned entry, one with dependents).

withUser now counts the queries in each transaction and says so in
development past a threshold. Without that, this grows back: each new
tile brings its own query, and nobody notices until everybody does.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

app/(app)/layout.tsx

@@ -4,46 +4,23 @@ import { HireWizardProvider } from "@/components/hire/HireWizardContext";
 import { AppShell } from "@/components/shell/AppShell";
 import { currentUserId } from "@/lib/auth/session";
 import { withUser } from "@/lib/db";
-import { loadOpenNotes } from "@/lib/notes";
-import { loadOpenPositions } from "@/lib/positions";
+import { loadShellData } from "@/lib/shell-data";
 
 export default async function AppLayout({ children }: { children: ReactNode }) {
   const userId = await currentUserId();
   if (!userId) redirect("/login");
 
   // Alles in *einer* Transaktion, weil nur dort der Sitzungskontext gilt —
-  // und damit nebenbei auf einem einheitlichen Lesestand.
-  const data = await withUser(userId, async (tx) => {
-    // Hier — und nicht im Proxy — fällt die Entscheidung über den Zugang.
-    // Der Proxy prüft nur, ob überhaupt jemand angemeldet ist; er hat keine
-    // Datenbankverbindung. Diese Abfrage läuft bei jedem Aufbau frisch, eine
-    // entzogene Freischaltung wirkt also sofort statt erst mit dem nächsten
-    // Sitzungstoken. Die eigentliche Grenze bleibt darunter RLS.
-    const profile = await tx
-      .selectFrom("profiles")
-      .select(["full_name", "email", "role", "is_active"])
-      .where("id", "=", userId)
-      .executeTakeFirst();
-    if (profile?.role !== "hr" || profile?.is_active !== true) return null;
-
-    const [openPositions, locations, drafts, openNotes] = await Promise.all([
-      loadOpenPositions(tx),
-      tx.selectFrom("locations").select(["id", "name", "country"]).orderBy("name").execute(),
-      tx
-        .selectFrom("hire_drafts")
-        .select(["id", "step", "payload", "updated_at"])
-        .where("created_by", "=", userId)
-        .orderBy("updated_at", "desc")
-        .execute(),
-      loadOpenNotes(tx),
-    ]);
-
-    return { profile, openPositions, locations, drafts, openNotes };
-  });
+  // und damit nebenbei auf einem einheitlichen Lesestand. Was dabei in wie
+  // vielen Rundreisen gelesen wird, steht in lib/shell-data.ts.
+  const data = await withUser(userId, (tx) => loadShellData(tx, userId));
 
   // `data` ist null, wenn die Person angemeldet, aber nicht freigeschaltet
-  // ist. Ohne den Grund in der Adresse stünde sie vor einer wortlosen
-  // Anmeldeseite und versuchte es endlos erneut.
+  // ist. Hier — und nicht im Proxy — fällt diese Entscheidung: der Proxy hat
+  // keine Datenbankverbindung. Sie wird bei jedem Aufbau frisch gestellt, eine
+  // entzogene Freischaltung wirkt also sofort statt erst mit dem nächsten
+  // Sitzungstoken. Ohne den Grund in der Adresse stünde die Person vor einer
+  // wortlosen Anmeldeseite und versuchte es endlos erneut.
   if (!data) redirect("/login?error=no_hr_access");
 
   const userLabel = data.profile.full_name || data.profile.email || "";