Consolidation pass: HR-only access, effective-dated mutations, data integrity guards, test suite

Reworks the app from a two-role (hr_admin/manager) model to a single HR-only role gated by profiles.is_active, fixes transfer/promote/karenz/ reorg RPCs to actually defer future-dated changes via a new pending_org_changes table instead of writing them immediately (applied by a daily Vercel Cron route), makes reorg undo append-only instead of deleting history, adds Karenz-return and history-date integrity guards, deprecates the salary column, and adds explicit schema grants + perf indexes needed to run against a fresh (non-hosted) Postgres instance. Adds vitest unit + integration test suites (the latter against a real local Supabase instance) covering all of the above, plus lint/typecheck/ build wiring (`npm run check`).
2026-07-14 20:32:20 +02:00
parent 4299277af0
commit 901c5c426e
67 changed files with 4765 additions and 286 deletions
--- a/components/employees/EmployeeDetail.tsx
+++ b/components/employees/EmployeeDetail.tsx
@@ -17,7 +17,7 @@ import { OrganisationTab } from "./tabs/OrganisationTab";
 import { StammdatenTab } from "./tabs/StammdatenTab";
 import { VertragTab } from "./tabs/VertragTab";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
 type Division = Database["public"]["Tables"]["divisions"]["Row"];
 type Department = Database["public"]["Tables"]["departments"]["Row"];
 type Team = Database["public"]["Tables"]["teams"]["Row"];
@@ -36,14 +36,13 @@ type EmployeeDetailProps = {
  teams: Team[];
  locations: Location[];
  openPositions: OpenPosition[];
-  canEdit: boolean;
 };

 type PanelType = "transfer" | "promote" | "karenz" | "daten" | "terminate" | "rehire" | null;
-const TABS = ["Stammdaten", "Vertrag & Gehalt", "Organisation", "Historie"] as const;
+const TABS = ["Stammdaten", "Vertrag", "Organisation", "Historie"] as const;

 export function EmployeeDetail(props: EmployeeDetailProps) {
-  const { employee, manager, directReports, history, divisions, departments, teams, locations, canEdit } = props;
+  const { employee, manager, directReports, history, divisions, departments, teams, locations } = props;
  const [tab, setTab] = useState<(typeof TABS)[number]>("Stammdaten");
  const [panel, setPanel] = useState<PanelType>(null);

@@ -77,32 +76,30 @@ export function EmployeeDetail(props: EmployeeDetailProps) {
            </div>
          </div>

-          {canEdit && (
-            <div className="flex flex-wrap gap-2">
-              {isActive && (
-                <>
-                  <ActionButton icon={ArrowRightLeft} label="Versetzen" onClick={() => setPanel("transfer")} />
-                  <ActionButton icon={TrendingUp} label="Befördern" onClick={() => setPanel("promote")} />
-                  <ActionButton icon={Clock} label={employee.status === "Karenz" ? "Karenz verwalten" : "Karenz"} onClick={() => setPanel("karenz")} />
-                  <ActionButton icon={Pencil} label="Daten ändern" onClick={() => setPanel("daten")} />
-                  <button
-                    onClick={() => setPanel("terminate")}
-                    className="flex items-center gap-1.5 rounded border border-danger-solid px-3 py-1.5 text-sm font-semibold text-danger-solid hover:bg-danger-bg"
-                  >
-                    <XCircle className="h-4 w-4" /> Austritt
-                  </button>
-                </>
-              )}
-              {employee.status === "Ausgetreten" && (
+          <div className="flex flex-wrap gap-2">
+            {isActive && (
+              <>
+                <ActionButton icon={ArrowRightLeft} label="Versetzen" onClick={() => setPanel("transfer")} />
+                <ActionButton icon={TrendingUp} label="Befördern" onClick={() => setPanel("promote")} />
+                <ActionButton icon={Clock} label={employee.status === "Karenz" ? "Karenz verwalten" : "Karenz"} onClick={() => setPanel("karenz")} />
+                <ActionButton icon={Pencil} label="Daten ändern" onClick={() => setPanel("daten")} />
                <button
-                  onClick={() => setPanel("rehire")}
-                  className="flex items-center gap-1.5 rounded bg-brand-500 px-3 py-1.5 text-sm font-semibold text-white hover:bg-brand-600"
+                  onClick={() => setPanel("terminate")}
+                  className="flex items-center gap-1.5 rounded border border-danger-solid px-3 py-1.5 text-sm font-semibold text-danger-solid hover:bg-danger-bg"
                >
-                  <RotateCcw className="h-4 w-4" /> Wiedereinstellen
+                  <XCircle className="h-4 w-4" /> Austritt
                </button>
-              )}
-            </div>
-          )}
+              </>
+            )}
+            {employee.status === "Ausgetreten" && (
+              <button
+                onClick={() => setPanel("rehire")}
+                className="flex items-center gap-1.5 rounded bg-brand-500 px-3 py-1.5 text-sm font-semibold text-white hover:bg-brand-600"
+              >
+                <RotateCcw className="h-4 w-4" /> Wiedereinstellen
+              </button>
+            )}
+          </div>
        </div>
      </div>

@@ -122,29 +119,25 @@ export function EmployeeDetail(props: EmployeeDetailProps) {

      <div className="rounded border border-border bg-white p-6">
        {tab === "Stammdaten" && <StammdatenTab employee={employee} location={location} />}
-        {tab === "Vertrag & Gehalt" && <VertragTab employee={employee} />}
+        {tab === "Vertrag" && <VertragTab employee={employee} />}
        {tab === "Organisation" && <OrganisationTab manager={manager} directReports={directReports} breadcrumb={breadcrumb} />}
        {tab === "Historie" && <HistorieTab history={history} />}
      </div>

-      {canEdit && (
-        <>
-          <TransferPanel
-            open={panel === "transfer"}
-            onClose={() => setPanel(null)}
-            employee={employee}
-            divisions={divisions}
-            departments={departments}
-            teams={teams}
-            currentTeamId={employee.team_id}
-          />
-          <PromotePanel open={panel === "promote"} onClose={() => setPanel(null)} employee={employee} />
-          <KarenzPanel open={panel === "karenz"} onClose={() => setPanel(null)} employee={employee} />
-          <DatenAendernPanel open={panel === "daten"} onClose={() => setPanel(null)} employee={employee} />
-          <TerminatePanel open={panel === "terminate"} onClose={() => setPanel(null)} employee={employee} directReportCount={directReports.length} />
-          <RehirePanel open={panel === "rehire"} onClose={() => setPanel(null)} employee={employee} />
-        </>
-      )}
+      <TransferPanel
+        open={panel === "transfer"}
+        onClose={() => setPanel(null)}
+        employee={employee}
+        divisions={divisions}
+        departments={departments}
+        teams={teams}
+        currentTeamId={employee.team_id}
+      />
+      <PromotePanel open={panel === "promote"} onClose={() => setPanel(null)} employee={employee} />
+      <KarenzPanel open={panel === "karenz"} onClose={() => setPanel(null)} employee={employee} />
+      <DatenAendernPanel open={panel === "daten"} onClose={() => setPanel(null)} employee={employee} />
+      <TerminatePanel open={panel === "terminate"} onClose={() => setPanel(null)} employee={employee} directReportCount={directReports.length} />
+      <RehirePanel open={panel === "rehire"} onClose={() => setPanel(null)} employee={employee} />
    </div>
  );
 }
--- a/components/employees/panels/DatenAendernPanel.tsx
+++ b/components/employees/panels/DatenAendernPanel.tsx
@@ -9,7 +9,7 @@ import { useToast } from "@/components/ui/Toast";
 import { UN_COUNTRIES } from "@/lib/countries";
 import type { ContractType, Database, EmploymentType, GenderType } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];

 export function DatenAendernPanel({ open, onClose, employee }: { open: boolean; onClose: () => void; employee: EmployeeRow }) {
  const { showToast } = useToast();
--- a/components/employees/panels/KarenzPanel.tsx
+++ b/components/employees/panels/KarenzPanel.tsx
@@ -9,7 +9,7 @@ import { useToast } from "@/components/ui/Toast";
 import { fmtDate } from "@/lib/format";
 import type { Database } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
 type Mode = "adjust" | "return";
 type EmploymentMode = "unverändert" | "Vollzeit" | "Teilzeit";

--- a/components/employees/panels/PromotePanel.tsx
+++ b/components/employees/panels/PromotePanel.tsx
@@ -7,7 +7,7 @@ import { SlideOver } from "@/components/ui/SlideOver";
 import { useToast } from "@/components/ui/Toast";
 import type { Database, PaygradeType } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];

 const PAYGRADES: { value: PaygradeType; label: string }[] = [
  { value: "A", label: "A – Einstieg" },
@@ -23,12 +23,11 @@ export function PromotePanel({ open, onClose, employee }: { open: boolean; onClo
  const router = useRouter();
  const [effectiveDate, setEffectiveDate] = useState("");
  const [newTitle, setNewTitle] = useState(employee.job_title);
-  const [newSalary, setNewSalary] = useState(String(employee.monthly_salary_gross ?? ""));
  const [paygrade, setPaygrade] = useState<PaygradeType>(employee.paygrade);
  const [pending, setPending] = useState(false);

  async function handleSubmit() {
-    if (!effectiveDate || !newTitle || !newSalary) {
+    if (!effectiveDate || !newTitle) {
      showToast("Bitte alle Pflichtfelder ausfüllen.", "error");
      return;
    }
@@ -37,7 +36,6 @@ export function PromotePanel({ open, onClose, employee }: { open: boolean; onClo
      employee_id: employee.id,
      effective_date: effectiveDate,
      new_title: newTitle,
-      new_salary: Number(newSalary),
      new_paygrade: paygrade,
    });
    setPending(false);
@@ -85,15 +83,6 @@ export function PromotePanel({ open, onClose, employee }: { open: boolean; onClo
          <label className="mb-1 block text-sm font-semibold text-ink">Neue Position*</label>
          <input value={newTitle} onChange={(e) => setNewTitle(e.target.value)} className="w-full rounded border border-border px-3 py-2 text-sm" />
        </div>
-        <div>
-          <label className="mb-1 block text-sm font-semibold text-ink">Neues Bruttogehalt (14x/Jahr)*</label>
-          <input
-            type="number"
-            value={newSalary}
-            onChange={(e) => setNewSalary(e.target.value)}
-            className="w-full rounded border border-border px-3 py-2 text-sm"
-          />
-        </div>
        <div>
          <label className="mb-1 block text-sm font-semibold text-ink">Paygrade</label>
          <select
--- a/components/employees/panels/RehirePanel.tsx
+++ b/components/employees/panels/RehirePanel.tsx
@@ -8,7 +8,7 @@ import { useToast } from "@/components/ui/Toast";
 import { fmtDate } from "@/lib/format";
 import type { Database } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];

 export function RehirePanel({ open, onClose, employee }: { open: boolean; onClose: () => void; employee: EmployeeRow }) {
  const { showToast } = useToast();
--- a/components/employees/panels/TerminatePanel.tsx
+++ b/components/employees/panels/TerminatePanel.tsx
@@ -7,7 +7,7 @@ import { SlideOver } from "@/components/ui/SlideOver";
 import { useToast } from "@/components/ui/Toast";
 import type { Database } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];

 const EXIT_REASONS = ["Einvernehmliche Auflösung", "Kündigung AN", "Kündigung AG", "Befristungsablauf", "Pensionierung", "Entlassung"];
 const CHECKLIST_ITEMS = ["IT-Zugänge deaktivieren", "Hardware retournieren", "ÖGK-Abmeldung", "Endabrechnung & Dienstzeugnis"];
--- a/components/employees/panels/TransferPanel.tsx
+++ b/components/employees/panels/TransferPanel.tsx
@@ -7,7 +7,7 @@ import { SlideOver } from "@/components/ui/SlideOver";
 import { useToast } from "@/components/ui/Toast";
 import type { Database } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
 type Division = Database["public"]["Tables"]["divisions"]["Row"];
 type Department = Database["public"]["Tables"]["departments"]["Row"];
 type Team = Database["public"]["Tables"]["teams"]["Row"];
--- a/components/employees/tabs/StammdatenTab.tsx
+++ b/components/employees/tabs/StammdatenTab.tsx
@@ -1,7 +1,7 @@
 import { fmtAge, fmtDate } from "@/lib/format";
 import type { Database } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];
 type Location = Database["public"]["Tables"]["locations"]["Row"];

 export function StammdatenTab({ employee, location }: { employee: EmployeeRow; location?: Location }) {
--- a/components/employees/tabs/VertragTab.tsx
+++ b/components/employees/tabs/VertragTab.tsx
@@ -1,7 +1,7 @@
-import { fmtDate, fmtEUR } from "@/lib/format";
+import { fmtDate } from "@/lib/format";
 import type { Database } from "@/lib/supabase/types";

-type EmployeeRow = Database["public"]["Views"]["employees_directory"]["Row"];
+type EmployeeRow = Database["public"]["Tables"]["employees"]["Row"];

 const PAYGRADE_LABELS: Record<string, string> = {
  A: "A – Einstieg",
@@ -21,7 +21,6 @@ export function VertragTab({ employee }: { employee: EmployeeRow }) {
    ["Wochenstunden", `${employee.weekly_hours} h`],
    ["Urlaubsanspruch", "25 Tage"],
    ["Paygrade", PAYGRADE_LABELS[employee.paygrade] ?? employee.paygrade],
-    ["Bruttogehalt (14x/Jahr)", fmtEUR(employee.monthly_salary_gross)],
  ];
  if (employee.exit_date) rows.push(["Austrittsdatum", fmtDate(employee.exit_date)]);