SVNR validation, CI, and a dependency/security pass

Positions
- Removed the "Besetzen" action, the StaffInternallyModal behind it and the
  now-unreachable staffPositionInternally server action: a position is filled
  through the hire process, not from the positions list. Note that
  transfer_employee has no position_id at all and never touched `positions`,
  so with staff_position_internally out of the UI, hire_employee is the only
  thing that closes a position — a transfer into an open one leaves it open.
  The RPC itself is still in the database and still covered by its tests.

SVNR
- Austrian social security numbers are now validated: ten digits, weighted
  check digit mod 11, and the TTMMJJ tail cross-checked against birth_date,
  which is what catches a transposed date that a valid check digit would let
  through. A serial whose weighted sum lands on 11 is rejected rather than
  wrapped — those are never issued.
- Applies to Austrian locations only; the German/Czech/Slovenian equivalents
  have their own formats and stay free-form.
- Enforced by a trigger, not inside hire_employee/change_employee_data, for
  the same reason as the assignment history: both have been redefined by
  half a dozen migrations. Only a *newly written* value is checked, so a
  legacy number never blocks an unrelated transfer or address change.
- The seed drew a random four-digit prefix, so its check digit was right
  only by chance and every seeded Austrian row would now be rejected;
  it computes the check digit properly now.

Tech stack
- next 16.2.11 closes nine advisories against 16.2.10, including a
  middleware/proxy bypass in App Router apps on Turbopack — proxy.ts is this
  app's entry gate. RLS remains the real boundary, so the blast radius was a
  blank page rather than data, but it is a patch-level fix. Also react
  19.2.8, tailwind 4.3.3, lucide-react 1.26, supabase-js/ssr, postcss.
- CI runs lint, typecheck, schema/type drift, tests and build; a second job
  replays every migration onto an empty database and runs the integration
  suite against it, so a migration that cannot be replayed from scratch
  fails here instead of during a restore.
- scripts/check-schema-types.mjs diffs the hand-written lib/supabase/types.ts
  against the migrations. Reading the SQL rather than a live database keeps
  Postgres out of the fast CI job. Verified in both directions.
- vitest now runs two projects: node for logic, jsdom for components. The
  first component test covers the org chart expand control, which broke
  earlier this session when elementsSelectable={false} made React Flow
  compute pointer-events:none for the whole node; re-introducing that prop
  fails three of these tests.
- Content-Security-Policy is emitted report-only. Enforcing a policy derived
  from inspection rather than from violation reports risks blanking the app;
  'unsafe-inline' on script-src is required until a nonce is threaded through
  proxy.ts, which is a separate change.
- Fixed supabase/seed.ts, which this session's SVNR change had broken: the
  extensionless "../lib/svnr" import does not resolve under Node's ESM
  loader, so the seed failed at startup.
- engines pinned to node >=22 <25, tsconfig target ES2022, and the dead
  test:e2e script removed (no Playwright is installed).
This commit is contained in:
2026-07-25 11:13:10 +02:00
parent 79f0e19bf8
commit 8d978981b0
24 changed files with 1956 additions and 335 deletions

View File

@@ -0,0 +1,122 @@
import type { SupabaseClient } from "@supabase/supabase-js";
import { afterAll, beforeAll, describe, expect, it } from "vitest";
import type { Database } from "@/lib/supabase/types";
import { adminClient, createHrUser, deleteTestEmployee, deleteTestUser, hireTestEmployee, pickSeededTeam, signInAs, type TestUser } from "./helpers";
// SVNR validation (supabase/migrations/20260725120000_svnr_validation.sql).
// Enforced by a trigger, so these drive it through the real write paths and
// through a direct update — both must be covered by the same rule.
describe("SVNR validation", () => {
let hrUser: TestUser;
let hrClient: SupabaseClient<Database>;
let team: { id: string };
const employeeIds: string[] = [];
// 3·1 + 7·2 + 9·3 = 44; 010180 contributes 18; 62 mod 11 = 7
const VALID = "1237 010180";
const BIRTH_DATE = "1980-01-01";
async function locationIn(country: string): Promise<string> {
const { data } = await adminClient.from("locations").select("id").eq("country", country).limit(1).maybeSingle();
if (!data) throw new Error(`no seeded location in ${country}`);
return data.id;
}
beforeAll(async () => {
hrUser = await createHrUser({ active: true });
hrClient = await signInAs(hrUser);
team = await pickSeededTeam();
});
afterAll(async () => {
for (const id of employeeIds) await deleteTestEmployee(id);
await deleteTestUser(hrUser);
});
async function hireAt(country: string, overrides: Record<string, unknown> = {}): Promise<string> {
const id = await hireTestEmployee(hrClient, team.id, {
location_id: await locationIn(country),
birth_date: BIRTH_DATE,
...overrides,
});
employeeIds.push(id);
return id;
}
describe("is_valid_svnr", () => {
async function check(svnr: string, birthDate: string | null = null): Promise<boolean> {
const { data, error } = await adminClient.rpc("is_valid_svnr", { p_svnr: svnr, p_birth_date: birthDate });
if (error) throw new Error(error.message);
return data as unknown as boolean;
}
it("matches the TypeScript implementation on the documented cases", async () => {
expect(await check(VALID)).toBe(true);
expect(await check("1237010180")).toBe(true);
expect(await check("1234 010180")).toBe(false); // wrong check digit
expect(await check("0007 010180")).toBe(false); // 000 serial
expect(await check("0040 010180")).toBe(false); // check digit would be 10
expect(await check("1237 011380")).toBe(false); // month 13
expect(await check("123701018")).toBe(false); // nine digits
});
it("cross-checks the birth date when one is given", async () => {
expect(await check(VALID, BIRTH_DATE)).toBe(true);
expect(await check(VALID, "1980-01-02")).toBe(false);
});
});
describe("at an Austrian location", () => {
it("accepts a hire carrying a valid number", async () => {
const id = await hireAt("Österreich", { sv_nummer: VALID });
const { data } = await adminClient.from("employees").select("sv_nummer").eq("id", id).single();
expect(data?.sv_nummer).toBe(VALID);
});
it("rejects a hire carrying an invalid number", async () => {
await expect(hireAt("Österreich", { sv_nummer: "1234 010180" })).rejects.toThrow(/SV-Nummer/i);
});
it("rejects a number whose birth date disagrees with the employee record", async () => {
await expect(hireAt("Österreich", { sv_nummer: VALID, birth_date: "1975-06-30" })).rejects.toThrow(/SV-Nummer/i);
});
it("allows the field to stay empty", async () => {
const id = await hireAt("Österreich");
const { data } = await adminClient.from("employees").select("sv_nummer").eq("id", id).single();
expect(data?.sv_nummer ?? null).toBeNull();
});
it("rejects an update to an invalid number", async () => {
const id = await hireAt("Österreich", { sv_nummer: VALID });
const { error } = await adminClient.from("employees").update({ sv_nummer: "9999 010180" }).eq("id", id);
expect(error?.message ?? "").toMatch(/SV-Nummer/i);
});
});
describe("outside Austria", () => {
it("leaves the field free-form", async () => {
// The German equivalent has a different format entirely; validating it
// against the Austrian standard would reject correct data.
const id = await hireAt("Deutschland", { sv_nummer: "12 345678 A 901" });
const { data } = await adminClient.from("employees").select("sv_nummer").eq("id", id).single();
expect(data?.sv_nummer).toBe("12 345678 A 901");
});
});
describe("legacy rows", () => {
it("does not block an unrelated edit when the stored number is invalid", async () => {
// Rows predating the migration hold unvalidated values. A transfer or
// a name change must not fail because of a number nobody is touching.
const id = await hireAt("Deutschland", { sv_nummer: "0000 000000" });
const { error: moveError } = await adminClient
.from("employees")
.update({ location_id: await locationIn("Österreich") })
.eq("id", id);
expect(moveError).toBeNull();
const { error: nameError } = await adminClient.from("employees").update({ phone: "+43 1 9999999" }).eq("id", id);
expect(nameError).toBeNull();
});
});
});