SVNR validation, CI, and a dependency/security pass

Positions
- Removed the "Besetzen" action, the StaffInternallyModal behind it and the
  now-unreachable staffPositionInternally server action: a position is filled
  through the hire process, not from the positions list. Note that
  transfer_employee has no position_id at all and never touched `positions`,
  so with staff_position_internally out of the UI, hire_employee is the only
  thing that closes a position — a transfer into an open one leaves it open.
  The RPC itself is still in the database and still covered by its tests.

SVNR
- Austrian social security numbers are now validated: ten digits, weighted
  check digit mod 11, and the TTMMJJ tail cross-checked against birth_date,
  which is what catches a transposed date that a valid check digit would let
  through. A serial whose weighted sum lands on 11 is rejected rather than
  wrapped — those are never issued.
- Applies to Austrian locations only; the German/Czech/Slovenian equivalents
  have their own formats and stay free-form.
- Enforced by a trigger, not inside hire_employee/change_employee_data, for
  the same reason as the assignment history: both have been redefined by
  half a dozen migrations. Only a *newly written* value is checked, so a
  legacy number never blocks an unrelated transfer or address change.
- The seed drew a random four-digit prefix, so its check digit was right
  only by chance and every seeded Austrian row would now be rejected;
  it computes the check digit properly now.

Tech stack
- next 16.2.11 closes nine advisories against 16.2.10, including a
  middleware/proxy bypass in App Router apps on Turbopack — proxy.ts is this
  app's entry gate. RLS remains the real boundary, so the blast radius was a
  blank page rather than data, but it is a patch-level fix. Also react
  19.2.8, tailwind 4.3.3, lucide-react 1.26, supabase-js/ssr, postcss.
- CI runs lint, typecheck, schema/type drift, tests and build; a second job
  replays every migration onto an empty database and runs the integration
  suite against it, so a migration that cannot be replayed from scratch
  fails here instead of during a restore.
- scripts/check-schema-types.mjs diffs the hand-written lib/supabase/types.ts
  against the migrations. Reading the SQL rather than a live database keeps
  Postgres out of the fast CI job. Verified in both directions.
- vitest now runs two projects: node for logic, jsdom for components. The
  first component test covers the org chart expand control, which broke
  earlier this session when elementsSelectable={false} made React Flow
  compute pointer-events:none for the whole node; re-introducing that prop
  fails three of these tests.
- Content-Security-Policy is emitted report-only. Enforcing a policy derived
  from inspection rather than from violation reports risks blanking the app;
  'unsafe-inline' on script-src is required until a nonce is threaded through
  proxy.ts, which is a separate change.
- Fixed supabase/seed.ts, which this session's SVNR change had broken: the
  extensionless "../lib/svnr" import does not resolve under Node's ESM
  loader, so the seed failed at startup.
- engines pinned to node >=22 <25, tsconfig target ES2022, and the dead
  test:e2e script removed (no Playwright is installed).
This commit is contained in:
2026-07-25 11:13:10 +02:00
parent 79f0e19bf8
commit 8d978981b0
24 changed files with 1956 additions and 335 deletions

View File

@@ -0,0 +1,98 @@
import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { useCallback, useState } from "react";
import { describe, expect, it } from "vitest";
import { GraphOrgChart } from "@/components/orgchart/GraphOrgChart";
import type { ChartNode } from "@/components/orgchart/types";
// Regression cover for the graphical org chart. The expand control lives
// inside a React Flow custom node, and React Flow decides whether that node
// receives pointer events at all from the props passed to <ReactFlow>:
// setting elementsSelectable={false} alongside nodesDraggable={false} made it
// compute pointer-events:none for the whole card, so neither the toggle nor
// the employee link responded. Nothing in the type system catches that, and
// no logic test would either — it only shows up when the tree is rendered
// and actually clicked.
function person(id: string, name: string, children: ChartNode[] = []): ChartNode {
return {
id,
kind: "person",
label: name,
sublabel: "Testrolle",
href: `/employees/${id}`,
avatar: { firstName: name.split(" ")[0], lastName: name.split(" ")[1] ?? "X" },
totalReports: children.length,
children,
};
}
const TREE: ChartNode[] = [
person("1", "Johanna Wiesinger", [
person("2", "Markus Steinbacher", [person("4", "Katharina Aigner"), person("5", "Kurt Aigner")]),
person("3", "Simon Aigner"),
]),
];
function Harness({ initial = ["1"] }: { initial?: string[] }) {
const [expanded, setExpanded] = useState<Set<string>>(new Set(initial));
const onToggle = useCallback((id: string) => {
setExpanded((prev) => {
const next = new Set(prev);
if (next.has(id)) next.delete(id);
else next.add(id);
return next;
});
}, []);
const isExpanded = useCallback((id: string) => expanded.has(id), [expanded]);
return <GraphOrgChart tree={TREE} isExpanded={isExpanded} onToggle={onToggle} matchedIds={null} />;
}
describe("GraphOrgChart", () => {
it("renders the root and its expanded children", async () => {
render(<Harness />);
expect(await screen.findByText("Johanna Wiesinger")).toBeInTheDocument();
expect(screen.getByText("Markus Steinbacher")).toBeInTheDocument();
expect(screen.getByText("Simon Aigner")).toBeInTheDocument();
// Grandchildren stay hidden until their parent is expanded.
expect(screen.queryByText("Katharina Aigner")).not.toBeInTheDocument();
});
it("expands a collapsed branch when its control is clicked", async () => {
render(<Harness />);
await userEvent.click(await screen.findByRole("button", { name: /Markus Steinbacher aufklappen/i }));
expect(await screen.findByText("Katharina Aigner")).toBeInTheDocument();
expect(screen.getByText("Kurt Aigner")).toBeInTheDocument();
});
it("collapses again", async () => {
render(<Harness initial={["1", "2"]} />);
expect(await screen.findByText("Katharina Aigner")).toBeInTheDocument();
await userEvent.click(await screen.findByRole("button", { name: /Johanna Wiesinger zuklappen/i }));
expect(screen.queryByText("Markus Steinbacher")).not.toBeInTheDocument();
});
it("keeps the node's pointer events enabled", () => {
// The direct assertion on the regression: React Flow writes
// pointer-events onto the node wrapper as an inline style, and 'none'
// there silently disables everything inside the card.
const { container } = render(<Harness />);
const nodes = container.querySelectorAll<HTMLElement>(".react-flow__node");
expect(nodes.length).toBeGreaterThan(0);
for (const node of nodes) {
expect(node.style.pointerEvents).not.toBe("none");
}
});
it("shows the child count on a collapsed node and links to the employee", async () => {
render(<Harness />);
expect(await screen.findByRole("button", { name: /Markus Steinbacher aufklappen \(2\)/i })).toHaveTextContent("2");
expect(screen.getByRole("link", { name: /Johanna Wiesinger/i })).toHaveAttribute("href", "/employees/1");
});
it("gives a leaf no expand control", async () => {
render(<Harness />);
await screen.findByText("Simon Aigner");
expect(screen.queryByRole("button", { name: /Simon Aigner (auf|zu)klappen/i })).not.toBeInTheDocument();
});
});