Restore the shapes the application was written against
The app runs against a real database for the first time since the port, and two things were broken. Both were invisible to typecheck, lint, 192 tests and the build. Sign-in looped. Auth.js created the session and app_upsert_user() adopted the existing profiles id correctly — the row was in app_users, right id and all — but the proxy builds its own Auth.js instance from lib/auth/config.ts alone, and the session callback that copies token.uid onto session.user.id lived in auth.ts. So the proxy saw a session without an id, treated every signed-in user as signed out, and sent them back to /login. Click, flash, login page: from the outside it looked like the button did nothing. The callback moves to the config both instances share. auth.ts now spreads the base callbacks instead of replacing them, which is the mistake that would reintroduce this. The proxy test did not catch it because its fixture hands the handler a session that already has user.id — it tested the routing, not the shape Auth.js actually produces. Then the dashboard crashed on a.date.localeCompare. PostgREST returned JSON: a `date` arrived as "2026-08-03", a `numeric` as a number, and that is what lib/supabase/types.ts declares and what every sort, every date comparison and every status derivation assumes. The pg driver does the opposite — Date object and string respectively. The declarations stayed true to what the code believes; only the runtime value changed, which is why nothing flagged it. The driver is configured back to the declared shapes in lib/db/pool.ts, rather than rewriting 49 call sites. That also removes a timezone hazard: `date` is a calendar day, and as a Date object it acquires midnight in the server's zone — a birth date would shift by a day in Austria, always. The same class of bug as in the seed. int8 stays a string on purpose: it only comes from count() and is read through Number() everywhere; parsed as a number it would quietly lose precision past 2^53. A missing sign-in error now reaches the server log. Auth.js was failing silently — a 302 back to /login and nothing to read. That was its own defect, and it is the reason the first diagnosis took as long as it did. Verified against the live database: all six pages render, 797 active of 852 records, 744.4 FTE, and a detail page shows birth date 15.08.1968 against SV number 7960 150868 — the digits agree, so no day has shifted. Both new tests were checked by mutation: remove the fix and they fail. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,40 @@
|
||||
import "server-only";
|
||||
import { Pool } from "pg";
|
||||
import { Pool, types } from "pg";
|
||||
|
||||
// ═══ Wie Werte aus der Datenbank ankommen ════════════════════════
|
||||
//
|
||||
// Der Wechsel des Zugriffswegs hat hier eine Falle hinterlassen, die kein
|
||||
// Typprüfer und keiner der Tests fangen konnte.
|
||||
//
|
||||
// Die alte API-Schicht lieferte JSON: ein `date` kam als "2026-08-03" an,
|
||||
// ein `numeric` als Zahl. Genau so steht es in lib/supabase/types.ts, und
|
||||
// darauf baut die gesamte Anwendung — Sortierungen mit localeCompare,
|
||||
// Vergleiche wie `entry_date <= stichtag`, das Ableiten des Status.
|
||||
//
|
||||
// Der `pg`-Treiber macht es anders herum: aus `date` wird ein Date-Objekt,
|
||||
// aus `numeric` eine Zeichenkette. Die Deklarationen blieben dabei
|
||||
// unverändert gültig — sie beschreiben ja nur, was der Code *glaubt*. Der
|
||||
// Fehler zeigt sich erst zur Laufzeit, und im günstigen Fall als Absturz
|
||||
// („a.date.localeCompare is not a function"). Im ungünstigen Fall gar
|
||||
// nicht: ein Datumsvergleich zwischen Date und Zeichenkette wirft nicht, er
|
||||
// liefert bloss das falsche Ergebnis.
|
||||
//
|
||||
// Deshalb wird der Treiber hier auf die Form zurückgestellt, die die Typen
|
||||
// beschreiben. Das ist die kleinere und ehrlichere Änderung, als 49
|
||||
// Abfragestellen umzuschreiben.
|
||||
//
|
||||
// Nebenbei löst es ein zweites Problem: `date` ist ein Kalendertag ohne
|
||||
// Zeitzone. Als Date-Objekt bekäme er eine — Mitternacht in der Zone des
|
||||
// Servers —, und ein Geburtsdatum verschöbe sich beim Formatieren um einen
|
||||
// Tag. Dieselbe Klasse von Fehler wie im Seed.
|
||||
types.setTypeParser(1082, (v) => v); // date → "YYYY-MM-DD", unverändert
|
||||
types.setTypeParser(1184, (v) => new Date(v).toISOString()); // timestamptz → ISO-8601 mit Z
|
||||
types.setTypeParser(1114, (v) => new Date(v + "Z").toISOString()); // timestamp ohne Zone
|
||||
types.setTypeParser(1700, (v) => Number(v)); // numeric → Zahl
|
||||
|
||||
// Bewusst *nicht* umgestellt: int8 (bigint). Es kommt nur aus count() und
|
||||
// wird überall mit Number() gelesen; als Zahl geparst verlöre es jenseits
|
||||
// von 2^53 stillschweigend an Genauigkeit.
|
||||
|
||||
// Die einzige Stelle im Projekt, die `pg` importieren darf.
|
||||
//
|
||||
|
||||
Reference in New Issue
Block a user