Ask for someone's organisation on a day they actually have one
An employee starting 01.09. showed "Keine Führungskraft (Geschäftsführung)" although their team has one — Josef Bauer, on chief position 60000752. The reporting line was requested as of today, and today that person holds no assignment, so om_reporting_lines() returned no row at all. The database function was right; the caller asked the wrong question. What made it look like a data problem rather than a date problem: the header did show the unit and the position, because pickPlacements() falls back to the next best assignment when none is current. Two notions of where someone sits — one forgiving, one strict — sitting next to each other on the same page. orgAsOf() pulls the date into the employment: the first day for someone not yet started, the last for someone who has left, today otherwise. Exit dates are exclusive throughout the model, so the last working day is the day before. Anyone already gone had the same defect for the same reason, which is why the rule covers both ends rather than special-casing the case that was reported. Verified against the live database: as of today no row, as of 2026-09-01 the manager is Josef Bauer. Six unit tests over the boundaries, checked by mutation — remove the future-entry branch and one fails. Open positions still resolve as of today: they belong to the organisation, not to the person whose file is open. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -4,7 +4,7 @@ import { currentUserId } from "@/lib/auth/session";
|
||||
import { withUser } from "@/lib/db";
|
||||
import { todayIso } from "@/lib/format";
|
||||
import { breadcrumbLabel, loadOrgMaps } from "@/lib/org";
|
||||
import { loadPlacements, loadReportingLines } from "@/lib/placement";
|
||||
import { loadPlacements, loadReportingLines, orgAsOf } from "@/lib/placement";
|
||||
import { loadOpenPositions } from "@/lib/positions";
|
||||
|
||||
type PageProps = { params: Promise<{ id: string }> };
|
||||
@@ -14,30 +14,39 @@ export default async function EmployeeDetailPage({ params }: PageProps) {
|
||||
const today = todayIso();
|
||||
|
||||
const data = await withUser(await currentUserId(), async (tx) => {
|
||||
// Die Person zuerst, allein: erst aus Eintritt und Austritt ergibt sich
|
||||
// der Stichtag, zu dem ihre Organisation überhaupt eine Antwort hat.
|
||||
// Eine Person, die am 01.09. anfängt, hat heute keine laufende Besetzung
|
||||
// — zu heute gefragt lieferte om_reporting_lines() nichts, und die Akte
|
||||
// behauptete „Keine Führungskraft", obwohl das Team eine hat.
|
||||
const employee = await tx.selectFrom("employees").selectAll().where("id", "=", id).executeTakeFirst();
|
||||
if (!employee) return null;
|
||||
|
||||
const asOf = orgAsOf(employee, today);
|
||||
|
||||
// Vorgesetzte und direkte Berichte stehen nirgends als Spalte — sie
|
||||
// kommen aus om_reporting_lines(). Beide Abfragen schränken *in* der
|
||||
// Funktion ein, es wandern also neun Zeilen über die Leitung und nicht
|
||||
// achthundert.
|
||||
const [employee, ownLines, reports, history, dependents, notes, orgMaps, placements, openPositions] =
|
||||
await Promise.all([
|
||||
tx.selectFrom("employees").selectAll().where("id", "=", id).executeTakeFirst(),
|
||||
loadReportingLines(tx, today, { employeeId: id }),
|
||||
loadReportingLines(tx, today, { actingManagerId: id }),
|
||||
tx
|
||||
.selectFrom("employee_history")
|
||||
.selectAll()
|
||||
.where("employee_id", "=", id)
|
||||
.orderBy("event_date", "desc")
|
||||
.orderBy("created_at", "desc")
|
||||
.execute(),
|
||||
tx.selectFrom("employee_dependents").selectAll().where("employee_id", "=", id).orderBy("created_at").execute(),
|
||||
tx.selectFrom("employee_notes").selectAll().where("employee_id", "=", id).orderBy("created_at", "desc").execute(),
|
||||
loadOrgMaps(tx),
|
||||
loadPlacements(tx, { asOf: today, employeeIds: [id] }),
|
||||
loadOpenPositions(tx),
|
||||
]);
|
||||
const [ownLines, reports, history, dependents, notes, orgMaps, placements, openPositions] = await Promise.all([
|
||||
loadReportingLines(tx, asOf, { employeeId: id }),
|
||||
loadReportingLines(tx, asOf, { actingManagerId: id }),
|
||||
tx
|
||||
.selectFrom("employee_history")
|
||||
.selectAll()
|
||||
.where("employee_id", "=", id)
|
||||
.orderBy("event_date", "desc")
|
||||
.orderBy("created_at", "desc")
|
||||
.execute(),
|
||||
tx.selectFrom("employee_dependents").selectAll().where("employee_id", "=", id).orderBy("created_at").execute(),
|
||||
tx.selectFrom("employee_notes").selectAll().where("employee_id", "=", id).orderBy("created_at", "desc").execute(),
|
||||
loadOrgMaps(tx),
|
||||
loadPlacements(tx, { asOf, employeeIds: [id] }),
|
||||
// Die offenen Planstellen bleiben bei heute: sie gehören zur
|
||||
// Organisation, nicht zu dieser Person.
|
||||
loadOpenPositions(tx),
|
||||
]);
|
||||
|
||||
if (!employee) return null;
|
||||
const line = ownLines[0] ?? null;
|
||||
|
||||
// Namen für die beteiligten Personen in einem Zug: die Vertretung, die
|
||||
|
||||
Reference in New Issue
Block a user